Skip to content

perf(files_reminders): Reduce db queries on propfind - #50244

Merged
Pytal merged 6 commits into
masterfrom
perf/cache-file-reminders
Feb 21, 2025
Merged

perf(files_reminders): Reduce db queries on propfind#50244
Pytal merged 6 commits into
masterfrom
perf/cache-file-reminders

Conversation

@Pytal

Copy link
Copy Markdown
Member

Summary

  • Add caching for reminders
  • Reduces database queries by n number of nodes in the directory per PROPFIND

Checklist

@PytalPytal added this to the Nextcloud 31 milestone Jan 17, 2025
@PytalPytal self-assigned this Jan 17, 2025
@icewind1991

This comment was marked as resolved.

@Pytal

This comment was marked as resolved.

@icewind1991

This comment was marked as resolved.

@Pytal
Pytalforce-pushed the perf/cache-file-reminders branch from f04cc38 to 17d93deCompareJanuary 24, 2025 22:27
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
Comment threadapps/files_reminders/lib/Db/ReminderMapper.php
Comment threadapps/files_reminders/lib/Service/ReminderService.php
@Pytal
Pytalforce-pushed the perf/cache-file-reminders branch from 17d93de to 7f72601CompareJanuary 31, 2025 22:52
@Pytal
Pytalforce-pushed the perf/cache-file-reminders branch from 7f72601 to 33ef228CompareFebruary 13, 2025 17:25
@Pytal
Pytal marked this pull request as ready for review February 13, 2025 17:25
@Pytal
Pytal requested review from a team, come-nc, icewind1991 and provokateurin and removed request for a teamFebruary 13, 2025 17:25
@Pytal
Pytalforce-pushed the perf/cache-file-reminders branch from e2edf02 to 48744e1CompareFebruary 20, 2025 22:13
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 20, 2025
@Pytal
Pytal enabled auto-merge February 20, 2025 22:16
@Pytal
Pytal disabled auto-merge February 20, 2025 22:21
@Pytal

Copy link
Copy Markdown
MemberAuthor

CI failure unrelated

Failure comes from #50910, cc @skjnldsv

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the perf/cache-file-reminders branch from d3d4445 to d249b60CompareFebruary 21, 2025 22:03
@Pytal
Pytal enabled auto-merge February 21, 2025 22:26
@Pytal
Pytal merged commit ceb6f56 into masterFeb 21, 2025
@Pytal
Pytal deleted the perf/cache-file-reminders branch February 21, 2025 22:27
@Pytal

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: filesperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@icewind1991@provokateurin@blizzz@skjnldsv