Skip to content

[stable31] perf(files_reminders): Reduce db queries on propfind - #51736

Merged
provokateurin merged 6 commits into
stable31from
backport/50244/stable31
Apr 28, 2025
Merged

[stable31] perf(files_reminders): Reduce db queries on propfind#51736
provokateurin merged 6 commits into
stable31from
backport/50244/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented Mar 26, 2025

Copy link
Copy Markdown

Backport of #50244

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzingerAndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger
AndyScherzingerforce-pushed the backport/50244/stable31 branch 2 times, most recently from e4817a5 to 243d942CompareApril 3, 2025 11:16
@nfebe
nfebe marked this pull request as ready for review April 23, 2025 22:17
@nfebe
nfebe enabled auto-merge April 23, 2025 22:17
@AndyScherzinger
AndyScherzingerforce-pushed the backport/50244/stable31 branch 2 times, most recently from 0fd12e5 to f1cd460CompareApril 24, 2025 05:24
@nfebe
nfebeforce-pushed the backport/50244/stable31 branch 2 times, most recently from da9ba28 to f4c2ae0CompareApril 24, 2025 09:30
@AndyScherzinger
AndyScherzingerforce-pushed the backport/50244/stable31 branch 5 times, most recently from 5516b14 to 88843f0CompareApril 27, 2025 20:57
@provokateurin

Copy link
Copy Markdown
Member

With the amount of failing CI I think we need to look into this properly. I'll try to make a manual backport of the original PR to see if that helps.

@provokateurin
provokateurin marked this pull request as draft April 28, 2025 05:54
auto-merge was automatically disabled April 28, 2025 05:54

Pull request was converted to draft

Pytal added 6 commits April 28, 2025 09:10
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@provokateurin
provokateurinforce-pushed the backport/50244/stable31 branch from 88843f0 to 338da85CompareApril 28, 2025 07:12
@provokateurin

provokateurin commented Apr 28, 2025

Copy link
Copy Markdown
Member

The source was probably the invalid PHP syntax 🤦‍♀️ https://github.com/nextcloud/server/actions/runs/14696045456/job/41237799482?pr=51736
And seeing the diff from my changes it seems like the rest of the backport was not done correctly either as most changes were actually missing.

@provokateurin
provokateurin marked this pull request as ready for review April 28, 2025 07:12
@provokateurin
provokateurin merged commit 96a12e7 into stable31Apr 28, 2025
@provokateurin
provokateurin deleted the backport/50244/stable31 branch April 28, 2025 08:20
@provokateurin

Copy link
Copy Markdown
Member

🎉

@blizzzblizzz mentioned this pull request May 5, 2025
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@provokateurin@AndyScherzinger@nfebe@Altahrim@skjnldsv@Pytal