Skip to content

fix(settings): Handle email change restriction separately from display name change restriction - #51745

Merged
skjnldsv merged 3 commits into
masterfrom
fix/settings/email-change-restriction
Apr 3, 2025
Merged

fix(settings): Handle email change restriction separately from display name change restriction#51745
skjnldsv merged 3 commits into
masterfrom
fix/settings/email-change-restriction

Conversation

@provokateurin

@provokateurinprovokateurin commented Mar 27, 2025•
edited by susnux
Loading

Copy link
Copy Markdown
Member

Summary

Not stored in the backends, so no need to touch those as well.

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Mar 27, 2025
@provokateurinprovokateurin added this to the Nextcloud 32 milestone Mar 27, 2025
@provokateurin
provokateurin requested review from a team as code ownersMarch 27, 2025 08:32
@provokateurin
provokateurin requested review from artonge, icewind1991, sorbaugh and susnux and removed request for a teamMarch 27, 2025 08:32
@provokateurin

provokateurin commented Mar 27, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@provokateurin

provokateurin commented Mar 27, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@provokateurin

provokateurin commented Mar 27, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@provokateurin
provokateurinforce-pushed the fix/settings/email-change-restriction branch from 784f4b6 to 92297ebCompareMarch 27, 2025 09:00
@provokateurin
provokateurinforce-pushed the fix/settings/email-change-restriction branch 2 times, most recently from 2e0bd9e to 9d48db7CompareMarch 28, 2025 11:13
@provokateurin

provokateurin commented Mar 28, 2025

Copy link
Copy Markdown
MemberAuthor

/compile

artonge
artonge reviewed Mar 31, 2025
View reviewed changes
Comment threadlib/private/User/User.php Outdated
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Outdated
susnux
susnux reviewed Apr 2, 2025
View reviewed changes
Comment threadlib/public/IUser.php Outdated
@susnux
susnuxforce-pushed the fix/settings/email-change-restriction branch from 0929491 to 53794d9CompareApril 2, 2025 16:38
@susnux
susnux requested a review from artongeApril 2, 2025 16:39
@susnux
susnuxforce-pushed the fix/settings/email-change-restriction branch 2 times, most recently from f0eccf5 to 5152b27CompareApril 2, 2025 16:49
@provokateurin@susnux@artonge
fix(settings): Handle email change restriction separately from displa…
eb98e99
…y name change restriction
Co-authored-by: provokateurin <kate@provokateurin.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor: add migration for email setting
e7859f0
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/settings/email-change-restriction branch from 5152b27 to e7859f0CompareApril 2, 2025 17:06
@susnux

susnux commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

/compile

@nextcloud-command
chore(assets): Recompile assets
7157787
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit fff9648 into masterApr 3, 2025
@skjnldsv
skjnldsv deleted the fix/settings/email-change-restriction branch April 3, 2025 06:19
This was referenced Apr 3, 2025
Merged
Merged
Merged
@nickvergessennickvergessen mentioned this pull request Apr 3, 2025
Merged
This was referenced Apr 10, 2025
Closed
Closed
@provokateurinprovokateurin added the pending documentation This pull request needs an associated documentation update label May 6, 2025
@provokateurinprovokateurin mentioned this pull request May 6, 2025
Merged
@provokateurinprovokateurin removed the pending documentation This pull request needs an associated documentation update label May 6, 2025
@provokateurinprovokateurin mentioned this pull request May 25, 2025
Merged
3 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@blizzzblizzzAwaiting requested review from blizzz
@artongeartongeAwaiting requested review from artonge

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Primary email cannot be changed/set 'allow_user_to_change_display_name' only affecting 'display name' not 'email address'

6 participants

@provokateurin@susnux@AndyScherzinger@artonge@skjnldsv@nextcloud-command