Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(settings): Handle email change restriction separately from display name change restriction - #51900
Merged
Merged
Conversation
backportbotBot
requested review from
AndyScherzinger, provokateurin, skjnldsv and susnuxApril 3, 2025 06:20
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange === true && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange === true && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
DeprecatedMethod
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange !== false && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange !== false && ( | ||
| $targetUser->getBackend() instanceof ISetDisplayNameBackend | ||
| || $targetUser->getBackend()->implementsActions(Backend::SET_DISPLAYNAME) |
Check notice
Code scanning / Psalm
DeprecatedMethod
susnuxforce-pushed
the
backport/51745/stable30
branch
from
April 3, 2025 06:42
747c3b9 to
9d1baceComparesusnux
approved these changes
Apr 3, 2025
susnux
marked this pull request as ready for review
April 3, 2025 06:42
susnuxforce-pushed
the
backport/51745/stable30
branch
from
April 3, 2025 06:45
9d1bace to
b8203ddComparesusnux
commented
Apr 3, 2025
Contributor
/compile |
| $accountParameters = [ | ||
| 'avatarChangeSupported' => $user->canChangeAvatar(), | ||
| 'displayNameChangeSupported' => $user->canChangeDisplayName(), | ||
| 'emailChangeSupported' => $user->canChangeEmail(), |
Check notice
Code scanning / Psalm
UndefinedInterfaceMethod
Contributor
There was a problem hiding this comment.
Yes but intentional.
Its not on the public interface (no backport of public interface changes), but on the private implementation.
| $permittedFields[] = IAccountManager::PROPERTY_DISPLAYNAME; | ||
| } | ||
| $allowDisplayNameChange = $this->config->getSystemValue('allow_user_to_change_display_name', true); | ||
| if ($allowDisplayNameChange !== false && ( |
Check notice
Code scanning / Psalm
PossiblyNullReference
AndyScherzinger
approved these changes
Apr 3, 2025
…y name change restriction Co-authored-by: provokateurin <kate@provokateurin.de> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Altahrimforce-pushed
the
backport/51745/stable30
branch
from
April 3, 2025 14:12
1af09b0 to
185e97bCompareAltahrim
commented
Apr 3, 2025
Collaborator
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51745
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.