Skip to content

fix(dav): add repair step to queue job to update rooms and resources - #52708

Merged
st3iny merged 1 commit into
masterfrom
fix/dav/update-rooms-resources-background-job
May 16, 2025
Merged

fix(dav): add repair step to queue job to update rooms and resources#52708
st3iny merged 1 commit into
masterfrom
fix/dav/update-rooms-resources-background-job

Conversation

@st3iny

@st3inyst3iny commented May 9, 2025

Copy link
Copy Markdown
Member

Summary

Add a repair step to re-queue the job to update rooms and resources in case it gets lost.

Checklist

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3inyst3iny self-assigned this May 9, 2025
@st3iny
st3iny requested a review from a team as a code ownerMay 9, 2025 15:22
@st3iny
st3iny removed the request for review from a teamMay 9, 2025 15:22
@st3inyst3iny added the bug label May 9, 2025
@st3inyst3iny added 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels May 9, 2025
@st3iny

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@st3iny

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@st3iny

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the info.xml entries take care of this already.

<job>OCA\DAV\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJob</job>

If not, could this be a server problem worth generalizing? As in, requeue any info.xml-registered job if it no longer exists.

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval despite #52708 (review) because this is acceptable as a quickfix

In general this should be done for any of these jobs

@st3iny

Copy link
Copy Markdown
MemberAuthor

I thought the info.xml entries take care of this already.

<job>OCA\DAV\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJob</job>

If not, could this be a server problem worth generalizing? As in, requeue any info.xml-registered job if it no longer exists.

I agree. I'll add this to my list to investigate.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: caldavRelated to CalDAV internalsfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add repair job to insert background job to update rooms and resources

4 participants

@st3iny@ChristophWurst@SebastianKrupinski@skjnldsv