Skip to content

[stable29] fix(dav): add repair step to queue job to update rooms and resources - #52902

Merged
AndyScherzinger merged 1 commit into
stable29from
backport/52708/stable29
May 28, 2025
Merged

[stable29] fix(dav): add repair step to queue job to update rooms and resources#52902
AndyScherzinger merged 1 commit into
stable29from
backport/52708/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented May 16, 2025

Copy link
Copy Markdown

Backport of PR #52708

@backportbotbackportbotBot added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels May 16, 2025
github-advanced-security[bot]
github-advanced-securityAI found potential problems May 16, 2025
View reviewed changes
Comment threadapps/dav/lib/Migration/RegisterUpdateCalendarResourcesRoomBackgroundJob.php Fixed
Comment threadapps/dav/lib/Migration/RegisterUpdateCalendarResourcesRoomBackgroundJob.php Fixed
Comment threadapps/dav/lib/Migration/RegisterUpdateCalendarResourcesRoomBackgroundJob.php
return 'Register a background job to update rooms and resources';
}

public function run(IOutput $output) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\DAV\Migration\RegisterUpdateCalendarResourcesRoomBackgroundJob::run does not have a return type, expecting void
Comment threadapps/dav/lib/Migration/RegisterUpdateCalendarResourcesRoomBackgroundJob.php Fixed
@ChristophWurst

ChristophWurst commented May 16, 2025

Copy link
Copy Markdown
Member

29 is EOL AFAIK

https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

@st3iny
fix(dav): add repair step to queue job to update rooms and resources
202cc5a
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the backport/52708/stable29 branch from 490ca2e to 202cc5aCompareMay 16, 2025 11:29
ChristophWurst
ChristophWurst approved these changes May 26, 2025
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 26, 2025
@AndyScherzinger
AndyScherzinger merged commit 0959cad into stable29May 28, 2025
@AndyScherzinger
AndyScherzinger deleted the backport/52708/stable29 branch May 28, 2025 23:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@st3inyst3inyst3iny approved these changes
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinski

Assignees

@st3inyst3iny

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: caldavRelated to CalDAV internalsfeature: dav

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@st3iny@github-advanced-security@AndyScherzinger