Uh oh!
There was an error while loading. Please reload this page.
fix(unified_search): Maintain filters when loading more results - #52772
Merged
Conversation
nfebeforce-pushed
the
fix/unified-search-filter-reset-on-load-more
branch
4 times, most recently
from
May 13, 2025 12:32
9c7dfbf to
75068cbComparenfebe
marked this pull request as ready for review
May 13, 2025 12:33
nfebe
requested review from
sorbaugh, susnux and szaimen
and removed request for
a teamMay 13, 2025 12:33
nfebe
enabled auto-merge
May 13, 2025 12:33
nfebe
commented
May 13, 2025
ContributorAuthor
/compile |
szaimen
removed their request for review
May 13, 2025 12:36
nfebeforce-pushed
the
fix/unified-search-filter-reset-on-load-more
branch
5 times, most recently
from
May 15, 2025 13:03
b425369 to
ca33261Comparenfebe
commented
May 15, 2025
ContributorAuthor
/compile |
susnux
approved these changes
May 15, 2025
skjnldsv
approved these changes
May 15, 2025
nfebeforce-pushed
the
fix/unified-search-filter-reset-on-load-more
branch
from
May 16, 2025 09:34
bd8fd2f to
41f6514Comparenfebe
commented
May 16, 2025
ContributorAuthor
/backport to stable31 |
nfebe
commented
May 16, 2025
ContributorAuthor
/backport to stable30 |
nfebe
commented
May 16, 2025
ContributorAuthor
/backport to stable29 |
nfebeforce-pushed
the
fix/unified-search-filter-reset-on-load-more
branch
from
May 16, 2025 09:44
41f6514 to
64b475aCompare…results Maintain existing non-provider filters (like date and person filters) while loading more results for a specific provider. This now works as the provider data passed to the `newResults` array after search is built dynamically and not manually, the result of a manual build was that the `provider.filters` properpy which is used in the `find` method was being left out in the providers pushed into the results array. Fixes#52081 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Before now the result limit is never reset until the page is refreshed. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/unified-search-filter-reset-on-load-more
branch
from
May 16, 2025 09:52
64b475a to
04f227aComparenfebe
commented
May 16, 2025
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintain existing filters (like date and person filters) while loading more results for a specific provider.
Fixes#52081