Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(unified_search): Maintain filters when loading more results - #52898
Closed
backportbot[bot] wants to merge 3 commits into
Closed
[stable29] fix(unified_search): Maintain filters when loading more results#52898backportbot[bot] wants to merge 3 commits into
backportbot[bot] wants to merge 3 commits into
Conversation
…results Maintain existing non-provider filters (like date and person filters) while loading more results for a specific provider. This now works as the provider data passed to the `newResults` array after search is built dynamically and not manually, the result of a manual build was that the `provider.filters` properpy which is used in the `find` method was being left out in the providers pushed into the results array. Fixes#52081 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Before now the result limit is never reset until the page is refreshed. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
requested changes
May 16, 2025
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Needs closer review or backport from 30
skjnldsv
commented
Jul 11, 2025
Member
Closing as stale and EOL branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52772
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.