Uh oh!
There was an error while loading. Please reload this page.
chore: move streamCopy implementation from OC_Helper to OCP\Files - #52890
Merged
Conversation
susnux
requested review from
icewind1991, nfebe and yemkareems
and removed request for
a teamMay 15, 2025 22:09
Uh oh!
There was an error while loading. Please reload this page.
come-nc
approved these changes
May 16, 2025
The function was already there but called the legacy version. So moved the implementation and migrated all usages of it. Sadly the interface was slightly different so adjusted it to be compatible with both legacy and the OCP one. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
chore/move-stream-copy-implementation
branch
from
May 16, 2025 11:03
6df30fb to
585597fComparesusnux
commented
May 16, 2025
ContributorAuthor
@icewind1991 as we discussed completely removing The only way to solve this I see is:
|
…`streamCopy` if possible Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
chore/move-stream-copy-implementation
branch
from
May 16, 2025 15:28
585597f to
0f69648Compareprovokateurin
approved these changes
May 16, 2025
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The function was already there but called the legacy version. So moved the implementation and migrated all usages of it. Sadly the interface was slightly different so adjusted it to be compatible with both legacy and the OCP one.
Checklist