Skip to content

fix(files_versions): only close stream if still open, fixing S3 - #52937

Merged
susnux merged 1 commit into
masterfrom
fix/s3-versions
May 18, 2025
Merged

fix(files_versions): only close stream if still open, fixing S3#52937
susnux merged 1 commit into
masterfrom
fix/s3-versions

Conversation

@susnux

@susnuxsusnux commented May 18, 2025•
edited by SystemKeeper
Loading

Copy link
Copy Markdown
Contributor

Summary

streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error.

Checklist

@susnux
fix(files_versions): only close stream if still open, fixing S3
2dcadd2
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added this to the Nextcloud 32 milestone May 18, 2025
@susnux
susnux requested a review from SystemKeeperMay 18, 2025 14:50
@susnuxsusnux added the bug label May 18, 2025
@susnux
susnux requested a review from a team as a code ownerMay 18, 2025 14:50
@susnux
susnux requested review from Altahrim, ArtificialOwl and yemkareems and removed request for a teamMay 18, 2025 14:50
@susnux
susnux requested review from icewind1991 and removed request for ArtificialOwlMay 18, 2025 14:51
SystemKeeper
SystemKeeper approved these changes May 18, 2025
View reviewed changes

@SystemKeeperSystemKeeper left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't judge if it's the correct way, but fixes the tests I was having issues with.

@susnux
susnux merged commit 0e20d9e into masterMay 18, 2025
@susnux
susnux deleted the fix/s3-versions branch May 18, 2025 17:53
@solracsf

solracsf commented May 18, 2025

Copy link
Copy Markdown
Member

Worth backport it?

@susnux

susnux commented May 18, 2025

Copy link
Copy Markdown
ContributorAuthor

Worth backport it?

No only an issue on master. Caused by #52890

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeperSystemKeeperSystemKeeper approved these changes
@solracsfsolracsfsolracsf approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: object storagefeature: versions

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@solracsf@SystemKeeper@skjnldsv