Skip to content

fix: Pass over product name as capability - #53339

Merged
susnux merged 2 commits into
masterfrom
fix/product-name-capability
Jun 18, 2025
Merged

fix: Pass over product name as capability#53339
susnux merged 2 commits into
masterfrom
fix/product-name-capability

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jun 5, 2025

Copy link
Copy Markdown
Member

This is being used to set the title and should be exposed to clients and the frontend

document.title=`${this.pageHeading} - ${getCapabilities().theming?.productName??'Nextcloud'}`

@juliusknorr
juliusknorrforce-pushed the fix/product-name-capability branch from 880ce13 to 21cc315CompareJune 5, 2025 07:45
@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews labels Jun 5, 2025
@juliusknorrjuliusknorr added this to the Nextcloud 32 milestone Jun 5, 2025
@juliusknorr
juliusknorr marked this pull request as ready for review June 5, 2025 07:45
@juliusknorr
juliusknorr requested a review from a team as a code ownerJune 5, 2025 07:45
@juliusknorr
juliusknorr requested review from come-nc and yemkareems and removed request for a teamJune 5, 2025 07:45
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@susnux

susnux commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

See also #53321

But anyways it makes sense to pass the product name as capability

@juliusknorr
juliusknorrforce-pushed the fix/product-name-capability branch from 0525ffa to 842b414CompareJune 12, 2025 05:41
juliusknorrand others added 2 commits June 18, 2025 12:54
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/product-name-capability branch from 842b414 to 1d0915bCompareJune 18, 2025 10:58
@susnux
susnux merged commit 98871fe into masterJun 18, 2025
@susnux
susnux deleted the fix/product-name-capability branch June 18, 2025 15:10
@backportbot

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/53339/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 9f12d685 1d0915b3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53339/stable30

Error: Failed to push branch backport/53339/stable30: remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@susnux@skjnldsv@provokateurin