Skip to content

fix: Pass over product name as capability#53339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Jun 18, 2025
Merged

fix: Pass over product name as capability #53339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f12d68
fix: Pass over product name as capability
juliusknorr Jun 5, 2025
1d0915b
chore: update theming openAPI exports
susnux Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/theming/lib/Capabilities.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,7 @@ public function __construct(
* @return array{
* theming: array{
* name: string,
* productName: string,
* url: string,
* slogan: string,
* color: string,
Expand DownExpand Up@@ -94,6 +95,7 @@ public function getCapabilities() {
return [
'theming' => [
'name' => $this->theming->getName(),
'productName' => $this->theming->getProductName(),
'url' => $this->theming->getBaseUrl(),
'slogan' => $this->theming->getSlogan(),
'color' => $color,
Expand Down
4 changes: 4 additions & 0 deletions apps/theming/openapi.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,7 @@
"type": "object",
"required": [
"name",
"productName",
"url",
"slogan",
"color",
Expand All@@ -98,6 +99,9 @@
"name": {
"type": "string"
},
"productName": {
"type": "string"
},
"url": {
"type": "string"
},
Expand Down
7 changes: 7 additions & 0 deletions apps/theming/tests/CapabilitiesTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,7 @@ public static function dataGetCapabilities(): array {
return [
['name', 'url', 'slogan', '#FFFFFF', '#000000', 'logo', 'background', '#fff', '#000', 'http://absolute/', true, [
'name' => 'name',
'productName' => 'name',
'url' => 'url',
'slogan' => 'slogan',
'color' => '#FFFFFF',
Expand All@@ -71,6 +72,7 @@ public static function dataGetCapabilities(): array {
]],
['name1', 'url2', 'slogan3', '#01e4a0', '#ffffff', 'logo5', 'background6', '#fff', '#000', 'http://localhost/', false, [
'name' => 'name1',
'productName' => 'name1',
'url' => 'url2',
'slogan' => 'slogan3',
'color' => '#01e4a0',
Expand All@@ -88,6 +90,7 @@ public static function dataGetCapabilities(): array {
]],
['name1', 'url2', 'slogan3', '#000000', '#ffffff', 'logo5', 'backgroundColor', '#000000', '#ffffff', 'http://localhost/', true, [
'name' => 'name1',
'productName' => 'name1',
'url' => 'url2',
'slogan' => 'slogan3',
'color' => '#000000',
Expand All@@ -105,6 +108,7 @@ public static function dataGetCapabilities(): array {
]],
['name1', 'url2', 'slogan3', '#000000', '#ffffff', 'logo5', 'backgroundColor', '#000000', '#ffffff', 'http://localhost/', false, [
'name' => 'name1',
'productName' => 'name1',
'url' => 'url2',
'slogan' => 'slogan3',
'color' => '#000000',
Expand DownExpand Up@@ -134,6 +138,9 @@ public function testGetCapabilities(string $name, string $url, string $slogan, s
$this->theming->expects($this->once())
->method('getName')
->willReturn($name);
$this->theming->expects($this->once())
->method('getProductName')
->willReturn($name);
$this->theming->expects($this->once())
->method('getBaseUrl')
->willReturn($url);
Expand Down
4 changes: 4 additions & 0 deletions openapi.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4047,6 +4047,7 @@
"type": "object",
"required": [
"name",
"productName",
"url",
"slogan",
"color",
Expand All@@ -4066,6 +4067,9 @@
"name": {
"type": "string"
},
"productName": {
"type": "string"
},
"url": {
"type": "string"
},
Expand Down