Uh oh!
There was an error while loading. Please reload this page.
chore(config.sample.php): apply Nc coding standard - #54822
Conversation
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, but please add the entire directory to https://github.com/nextcloud/server/blob/master/.php-cs-fixer.dist.php
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
joshtrichards
commented
Sep 2, 2025
Yeah the regex is confused in the converter. Looking at it now. |
converter fixed and tested w/ backwards compatibility in PR nextcloud/nextcloud-config-converter#11 (will need a docker image update pushed to production before it'll be live) |
ChristophWurst
left a comment
There was a problem hiding this comment.
Backports might be painful for a while but 👍 since we are past feature freeze
Uh oh!
There was an error while loading. Please reload this page.
joshtrichards
commented
Sep 10, 2025
The Docker image used to do the conversion still needs a bump: The old version of the sync script is still running and it's currently breaking config documentation. I lack privileges to bump the image in Cc: @nickvergessen / etc. |
provokateurin
commented
Sep 10, 2025
susnux
commented
Sep 10, 2025
Should be fixed now |
joshtrichards
commented
Sep 11, 2025
Confirmed. Working now. Thanks! |
Summary
In preparation for some other re-organizing, documentation expansion/cleanup, and config sample related changes. Seemed best to get this easy (but large in terms of line count) one out of the way first in order to streamline future PR reviews.
Only change contained in this PR is running php-cs-lint w/ our coding standard against the config sample.
Shouldn't cause any problems with the nextcloud-config-converter best as I can tell (and if it does we can remedy it easily enough).
TODO
Checklist