Skip to content

chore(config.sample.php): apply Nc coding standard - #54822

Merged
provokateurin merged 2 commits into
masterfrom
jtr/refactor-conf-sample
Sep 9, 2025
Merged

chore(config.sample.php): apply Nc coding standard#54822
provokateurin merged 2 commits into
masterfrom
jtr/refactor-conf-sample

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented Sep 2, 2025

Copy link
Copy Markdown
Member

Summary

In preparation for some other re-organizing, documentation expansion/cleanup, and config sample related changes. Seemed best to get this easy (but large in terms of line count) one out of the way first in order to streamline future PR reviews.

Only change contained in this PR is running php-cs-lint w/ our coding standard against the config sample.

Shouldn't cause any problems with the nextcloud-config-converter best as I can tell (and if it does we can remedy it easily enough).

TODO

  • none

Checklist

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards added this to the Nextcloud 32 milestone Sep 2, 2025
@joshtrichards
joshtrichards requested a review from a team as a code ownerSeptember 2, 2025 17:22
@joshtrichardsjoshtrichards added the 3. to review Waiting for reviews label Sep 2, 2025
@joshtrichards
joshtrichards requested review from ArtificialOwl and leftybournes and removed request for a teamSeptember 2, 2025 17:22
@joshtrichardsjoshtrichards added the technical debt 🧱 🤔🚀 label Sep 2, 2025
@joshtrichardsjoshtrichards added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Sep 2, 2025

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@nickvergessen

nickvergessen commented Sep 2, 2025

Copy link
Copy Markdown
Member

@joshtrichards

Copy link
Copy Markdown
MemberAuthor

Yeah the regex is confused in the converter. Looking at it now.

@joshtrichards

joshtrichards commented Sep 3, 2025

Copy link
Copy Markdown
MemberAuthor

converter fixed and tested w/ backwards compatibility in PR nextcloud/nextcloud-config-converter#11

(will need a docker image update pushed to production before it'll be live)

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backports might be painful for a while but 👍 since we are past feature freeze

@nextcloud-botnextcloud-bot mentioned this pull request Sep 4, 2025
@provokateurin
provokateurin merged commit 966b880 into masterSep 9, 2025
198 checks passed
@provokateurin
provokateurin deleted the jtr/refactor-conf-sample branch September 9, 2025 09:23
@joshtrichards

Copy link
Copy Markdown
MemberAuthor

The Docker image used to do the conversion still needs a bump:

https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-translations-documentation-sync

The old version of the sync script is still running and it's currently breaking config documentation.

I lack privileges to bump the image in docker-ci so can someone with privs do so?

Cc: @nickvergessen / etc.

@provokateurin

Copy link
Copy Markdown
Member

@susnux

Copy link
Copy Markdown
Contributor

Should be fixed now

@joshtrichards

Copy link
Copy Markdown
MemberAuthor

Confirmed. Working now. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)technical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtrichards@nickvergessen@provokateurin@susnux@ChristophWurst@skjnldsv