fix(sample-config): Fix sample config so parsing works again

[nickvergessen]

• Followup to fix: Move system-level activity app settings to the sample config #55706

Before:

php -f convert.php ~/Nextcloud/33/server/config/config.sample.php config_sample_php_parameters.rst
Uncommon part count found in the sample config file (…/33/server/config/config.sample.php)!
<pre>Array
(
[0] => /**
* Activities in Team Folders and External Storages.
*
* By default, activities in team folders or external storages are only generated
* for the current user. This is due to a limitations in current implementations.
* This config flag makes activities in group folders and external storages work
* like in normal shares (when set to ``true``). WARNING: Enabling this comes with
* some CRITICAL trade-offs:
*
* - If team folder "Advanced Permissions" (ACLs) are used, activities do not
* respect the permissions and therefore all users see all activities, even
* for files and directories they do not have access to.
* - Users who had access to a team folder, share, or external storage can see
* activities in their stream and emails that happen after they are removed
* until they log in again.
* - Users who are newly added to a team folder, share, or external storage
* cannot see activities in their stream or emails that happen after they
* are added until they log in again.
*
* WARNING: Before enabling this, read the warning Activity app chapter.
*
* Defaults to ``false``
**/
'activity_use_cached_mountpoints' => false,
)
</pre>PHP Fatal error: Uncaught Webmozart\Assert\InvalidArgumentException: Expected a different value than "". in …/Repositories/nextcloud-config-converter/vendor/webmozart/assert/src/Assert.php:2074
Stack trace:
#0 …/Repositories/nextcloud-config-converter/vendor/webmozart/assert/src/Assert.php(795): Webmozart\Assert\Assert::reportInvalidArgument('...')
#1 …/Repositories/nextcloud-config-converter/vendor/webmozart/assert/src/Assert.php(68): Webmozart\Assert\Assert::notEq('', '', '')
#2 …/Repositories/nextcloud-config-converter/vendor/phpdocumentor/reflection-docblock/src/DocBlockFactory.php(92): Webmozart\Assert\Assert::stringNotEmpty('')
#3 …/Repositories/nextcloud-config-converter/convert.php(173): phpDocumentor\Reflection\DocBlockFactory->create('')
#4 {main}
thrown in …/Repositories/nextcloud-config-converter/vendor/webmozart/assert/src/Assert.php on line 2074

Afterwards

diff --git a/admin_manual/configuration_server/config_sample_php_parameters.rst b/admin_manual/configuration_server/config_sample_php_parameters.rst
index e22d58b8e..c0d6d3e6c 100644
--- a/admin_manual/configuration_server/config_sample_php_parameters.rst+++ b/admin_manual/configuration_server/config_sample_php_parameters.rst@@ -2053,6 +2054,57 @@ Defaults to:
- iOS client app ID: ``1125420102``
- F-Droid client: ``https://f-droid.org/packages/com.nextcloud.client/``
+Activity+--------++Options for the activity app.+++activity_expire_days+^^^^^^^^^^^^^^^^^^^^+++::++ 'activity_expire_days' => 365,++Retention of activities.++A daily cron job deletes all activities for all users which are older than+the number of days specified here.++Defaults to ``365``++activity_use_cached_mountpoints+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^+++::++ 'activity_use_cached_mountpoints' => false,++Activities in Team Folders and External Storages.++By default, activities in team folders or external storages are only generated+for the current user. This is due to a limitations in current implementations.+This config flag makes activities in group folders and external storages work+like in normal shares (when set to ``true``). WARNING: Enabling this comes with+some CRITICAL trade-offs:++- If team folder "Advanced Permissions" (ACLs) are used, activities do not+ respect the permissions and therefore all users see all activities, even+ for files and directories they do not have access to.+- Users who had access to a team folder, share, or external storage can see+ activities in their stream and emails that happen after they are removed+ until they log in again.+- Users who are newly added to a team folder, share, or external storage+ cannot see activities in their stream or emails that happen after they+ are added until they log in again.++WARNING: Before enabling this, read the warning Activity app chapter.++Defaults to ``false``+
Apps
----

[nickvergessen]

Push another commit that together with nextcloud/nextcloud-config-converter#13 renders warnings and notes as beautiful blocks

[nickvergessen]

/backport 5ef933f074d698 to stable31

[nickvergessen]

/backport 5ef933f074d698 to stable32

[backportbot]

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55777/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 5ef933ff 074d6982
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55777/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[nickvergessen]

Would need a backport of #54822 first, so skipping for now

[joshtrichards]

Push another commit that together with nextcloud/nextcloud-config-converter#13 renders warnings and notes as beautiful blocks

Nice!