Skip to content

Use PNGs for icons in activity emails - #5483

Merged
MorrisJobke merged 3 commits into
masterfrom
issue-5075-png-files-for-activity-emails
Jul 7, 2017
Merged

Use PNGs for icons in activity emails#5483
MorrisJobke merged 3 commits into
masterfrom
issue-5075-png-files-for-activity-emails

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 20, 2017•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

@nickvergessen
Add a flag to allow checking if SVGs are okay
8b0546e
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use PNG version of the icons for shipped activities
90fa276
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 13 milestone Jun 20, 2017
@nickvergessennickvergessen mentioned this pull request Jun 20, 2017
Merged
1 task
@nickvergessen
Fix tests
ca3a6ec
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

codecovBot commented Jun 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5483 into master will decrease coverage by 46.72%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #5483 +/- ##
============================================
- Coverage 54.14% 7.41% -46.73% - Complexity 22345 22394 +49 
============================================
Files 1380 1380 Lines 85551 85050 -501 Branches 1329 1329 ============================================
- Hits 46318 6305 -40013 - Misses 39233 78745 +39512
Impacted FilesCoverage ΔComplexity Δ
apps/sharebymail/lib/Activity.php0% <0%> (ø)39 <0> (+8)⬆️
settings/Activity/SecurityProvider.php0% <0%> (-88.47%)7 <1> (+2)
apps/files/lib/Activity/FavoriteProvider.php0% <0%> (ø)18 <0> (+4)⬆️
apps/files/lib/Activity/Provider.php0% <0%> (-17.55%)71 <0> (+16)
apps/dav/lib/CalDAV/Activity/Provider/Todo.php0% <0%> (ø)25 <0> (+1)⬆️
settings/Activity/Provider.php0% <0%> (ø)23 <1> (+1)⬆️
apps/comments/lib/Activity/Provider.php0% <0%> (-6%)22 <0> (+1)
...ps/files_sharing/lib/Activity/Providers/Groups.php0% <0%> (ø)17 <0> (+2)⬆️
apps/dav/lib/CalDAV/Activity/Provider/Event.php0% <0%> (ø)18 <0> (+1)⬆️
...pps/files_sharing/lib/Activity/Providers/Users.php0% <0%> (ø)23 <0> (+2)⬆️
... and 823 more

This was referenced Jun 20, 2017
Merged
Merged
Merged
@nickvergessen

nickvergessen commented Jul 5, 2017

Copy link
Copy Markdown
MemberAuthor

@daita@MorrisJobke@LukasReschke please review since we should backport this to 12, to get rid of the broken emails on gmail

@ArtificialOwl

ArtificialOwl commented Jul 5, 2017

Copy link
Copy Markdown
Member

Quickly tested with Circles, and it works ! Just that we need to be careful by the size of the png :]

MorrisJobke
MorrisJobke approved these changes Jul 7, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit b4deba2 into masterJul 7, 2017
@MorrisJobke
MorrisJobke deleted the issue-5075-png-files-for-activity-emails branch July 7, 2017 09:05
@nickvergessennickvergessen mentioned this pull request Jul 7, 2017
Merged
1 task
@st3inyst3iny mentioned this pull request Nov 5, 2020
Merged
@piratepirate mentioned this pull request Mar 27, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ArtificialOwlArtificialOwlArtificialOwl approved these changes
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: activity and notification

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ArtificialOwl@MorrisJobke