Skip to content

[stable12] Use PNG icons for activity emails and ios client - #5648

Merged
MorrisJobke merged 3 commits into
stable12from
backport-5483-png-files-for-activity-emails
Jul 7, 2017
Merged

[stable12] Use PNG icons for activity emails and ios client #5648
MorrisJobke merged 3 commits into
stable12from
backport-5483-png-files-for-activity-emails

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 7, 2017

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@ArtificialOwl

Copy link
Copy Markdown
Member

This was yesterday on master
selection_033


This is today on stable12
selection_032

@ArtificialOwl

Copy link
Copy Markdown
Member

looks like an issue with the webmail client, original mail on the server contains the right img src=""

@codecov

codecovBot commented Jul 7, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5648 into stable12 will decrease coverage by 0.13%.
The diff coverage is 4.71%.

@@ Coverage Diff @@## stable12 #5648 +/- ##
==============================================
- Coverage 54.19% 54.05% -0.14% - Complexity 22358 22442 +84 
==============================================
Files 1379 1379 Lines 85556 85769 +213 Branches 1329 1329 ==============================================
+ Hits 46363 46365 +2 - Misses 39193 39404 +211
Impacted FilesCoverage ΔComplexity Δ
...es_sharing/lib/Activity/Providers/RemoteShares.php0% <0%> (ø)17 <0> (+2)⬆️
...files_sharing/lib/Activity/Providers/Downloads.php0% <0%> (ø)17 <0> (+2)⬆️
...pps/files_sharing/lib/Activity/Providers/Users.php0% <0%> (ø)23 <0> (+2)⬆️
apps/dav/lib/CalDAV/Activity/Provider/Todo.php0% <0%> (ø)25 <0> (+1)⬆️
apps/files/lib/Activity/FavoriteProvider.php0% <0%> (ø)18 <0> (+4)⬆️
apps/files/lib/Activity/Provider.php13.69% <0%> (-3.85%)71 <0> (+16)
apps/systemtags/lib/Activity/Provider.php0% <0%> (ø)41 <0> (+2)⬆️
apps/sharebymail/lib/Activity.php0% <0%> (ø)39 <0> (+8)⬆️
...ps/files_sharing/lib/Activity/Providers/Groups.php0% <0%> (ø)17 <0> (+2)⬆️
apps/comments/lib/Activity/Provider.php5.82% <0%> (-0.18%)22 <0> (+1)
... and 11 more

@MorrisJobke
MorrisJobke merged commit a5182ab into stable12Jul 7, 2017
@MorrisJobke
MorrisJobke deleted the backport-5483-png-files-for-activity-emails branch July 7, 2017 12:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ArtificialOwl@MorrisJobke