Uh oh!
There was an error while loading. Please reload this page.
fix(sharing): Adapt share suggestions to match trusted servers configs - #55080
Conversation
dd038fb to
7dca29bCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
susnux
left a comment
There was a problem hiding this comment.
I do not fully understand how this is possible only on backend side.
Because with "show trusted servers as internal" the search request from the frontend is basically the same, both "internal shares" and "external shares" will search for remote type.
The difference is only that with "show trusted servers as internal" that only trusted servers should be shown in the "internal share" results, while all other remotes should still be listed in "external shares" results
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7dca29b to
9763088ComparetobiasKaminsky
commented
Sep 16, 2025
/backport to stable-31 |
9763088 to
cfda889Compare3e3a68b to
e93743fComparenfebe
commented
Sep 17, 2025
/compile |
600912f to
e08c77bCompare28ab7bf to
c68b379Comparec68b379 to
09f100cComparenfebe
commented
Oct 1, 2025
/compile |
7a2d805 to
b4654f7Comparenfebe
commented
Oct 2, 2025
/compile |
8eedbac to
7a9c82cComparenfebe
commented
Oct 6, 2025
/compile |
65dfd15 to
2467fafCompareWhen `show_federated_shares_to_trusted_servers_as_internal` is enabled but `show_federated_shares_as_internal` is not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers. Resolved: #54511 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2467faf to
c9bb6eeComparenfebe
commented
Oct 9, 2025
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
The backport to # Switch to the target branch and update it
git checkout stable-31
git pull origin stable-31
# Create the new backport branch
git checkout -b backport/55080/stable-31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick c1d9e22c c9bb6eed 8c7be09d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55080/stable-31Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/55080/stable-31') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
nfebe
commented
Oct 9, 2025
/backport to stable32 |
nfebe
commented
Oct 9, 2025
/backport to stable31 |
Uh oh!
There was an error while loading. Please reload this page.
When
show_federated_shares_to_trusted_servers_as_internalis enabled butshow_federated_shares_as_internalis not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers.Resolved: #54511