Uh oh!
There was an error while loading. Please reload this page.
[stable32] fix(sharing): Adapt share suggestions to match trusted servers configs - #55642
Merged
Conversation
artonge
approved these changes
Oct 10, 2025
nfebe
requested changes
Oct 10, 2025
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Requires adaption. Backport incomplete.
nickvergessen
previously requested changes
Oct 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
nfebe
commented
Oct 21, 2025
Contributor
Requires : #55893 |
When `show_federated_shares_to_trusted_servers_as_internal` is enabled but `show_federated_shares_as_internal` is not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers. Resolved: #54511 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com> [skip ci]
nfebeforce-pushed
the
backport/55080/stable32
branch
from
December 15, 2025 23:32
43bbcb5 to
da82f6fCompareThe federation app is not always installed, causing QueryException when `OCA\Federation\TrustedServers` is injected as a hard dependency. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
approved these changes
Dec 15, 2025
nfebe
commented
Dec 15, 2025
Contributor
/compile |
nfebe
marked this pull request as ready for review
December 15, 2025 23:36
nfebe
requested review from
skjnldsv and szaimen
and removed request for
a teamDecember 15, 2025 23:36
nfebe
requested review from
Altahrim, salmart-dev and sorbaugh
and removed request for
a teamDecember 15, 2025 23:36
nfebe
enabled auto-merge
December 15, 2025 23:40
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #55080
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.