Skip to content

fix: legal footer on public page - #55415

Merged
SebastianKrupinski merged 1 commit into
masterfrom
fix/issue-legal-footer
Dec 9, 2025
Merged

fix: legal footer on public page#55415
SebastianKrupinski merged 1 commit into
masterfrom
fix/issue-legal-footer

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Sep 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adjusted footer logic
  • Adjusted footer width and colour
image

Checklist

@SebastianKrupinskiSebastianKrupinski self-assigned this Sep 29, 2025
@SebastianKrupinskiSebastianKrupinski added the 3. to review Waiting for reviews label Sep 29, 2025
@SebastianKrupinski
SebastianKrupinski requested review from ArtificialOwl, leftybournes, nfebe, skjnldsv and susnux and removed request for a teamSeptember 29, 2025 19:45
@SebastianKrupinskiSebastianKrupinski added this to the Nextcloud 32.0.1 milestone Oct 2, 2025
@SebastianKrupinski

SebastianKrupinski commented Oct 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@blizzzblizzz mentioned this pull request Oct 14, 2025
Merged
ChristophWurst
ChristophWurst approved these changes Dec 9, 2025
View reviewed changes
Comment threadcore/css/public.scss Outdated
height: var(--default-line-height);
color: var(--color-text-maxcontrast);
white-space: nowrap;
display: inline-block;

@ChristophWurstChristophWurstDec 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going by the other blocks I think there is one indentation too many

Comment threadcore/css/public.scss Outdated
bottom: var(--body-container-margin);
background-color: var(--color-main-background);
transform: translateX(-50%);
background-color: rgba( var(--color-main-background-rgb, 255,255,255), 0.85 );

@ChristophWurstChristophWurstDec 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: rgba( var(--color-main-background-rgb, 255,255,255), 0.85 );
background-color: rgba( var(--color-main-background-rgb, 255,255,255), 0.85 );

@susnuxsusnuxDec 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RGB variants are discouraged. Also for consistency with the footer in other places it should be the same as .guestbox in guests.scss:

--color-text-maxcontrast: var(--color-text-maxcontrast-background-blur, var(--color-main-text));
color: var(--color-main-text);
background-color: var(--color-main-background-blur);
-webkit-backdrop-filter: var(--filter-background-blur);
backdrop-filter: var(--filter-background-blur);

@SebastianKrupinskiSebastianKrupinskiDec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux How is this now?

@SebastianKrupinski

SebastianKrupinski commented Dec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Updated screen capture

image

@SebastianKrupinski
fix: legal footer on public page
162ebfa
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski merged commit 4185dfb into masterDec 9, 2025
195 of 200 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the fix/issue-legal-footer branch December 9, 2025 17:05
@backportbotbackportbotBot mentioned this pull request Dec 9, 2025
Merged
2 tasks
@Antreesy

Antreesy commented Dec 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This breaks quite some public pages now, as not respecting footerVisible anymore.

I see that at least 5 apps (including Calendar) had this specifically disabled: https://github.com/search?q=org%3Anextcloud+setFooterVisible&type=code

@SebastianKrupinski

SebastianKrupinski commented Dec 29, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @Antreesy

Thanks for letting me know, I will have to adjust the condition again.

@SebastianKrupinskiSebastianKrupinski mentioned this pull request Jan 5, 2026
Merged
6 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
@SebastianKrupinskiSebastianKrupinski mentioned this pull request Jan 28, 2026
Closed
@DerDreschner

DerDreschner commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This PR introduced the following regression: #57673

@SebastianKrupinski: Could you have a look at it?

@susnuxsusnux mentioned this pull request Mar 30, 2026
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@susnuxsusnuxsusnux approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner automatically assigned from nextcloud/server-frontend
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@kesselbkesselbAwaiting requested review from kesselb

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@SebastianKrupinski@Antreesy@DerDreschner@ChristophWurst@susnux@AndyScherzinger