Skip to content

fix: adjust public page footer logic - #57348

Merged
nickvergessen merged 1 commit into
masterfrom
fix/adjust-public-page-footer-logic
Jan 8, 2026
Merged

fix: adjust public page footer logic#57348
nickvergessen merged 1 commit into
masterfrom
fix/adjust-public-page-footer-logic

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adjusted Logic to respect getFooterVisible() - false

Checklist

@SebastianKrupinski

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

Comment threadcore/templates/layout.public.php Outdated

@AntreesyAntreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, comparison with the original condition (before the 55415):

- <?php if (isset($template) && $template->getFooterVisible() && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?>+ <?php if ((!isset($template) || $template->getFooterVisible() !== false) && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?>

@SebastianKrupinski

Copy link
Copy Markdown
ContributorAuthor

@Antreesy

Does this address the issue you had?

@Antreesy

Copy link
Copy Markdown
Contributor

Does this address the issue you had?

Yes, tested for public rooms and call recordings in Talk

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinskiforce-pushed the fix/adjust-public-page-footer-logic branch from defe392 to 6b3d3fdCompareJanuary 7, 2026 15:16
@SebastianKrupinski

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@nickvergessen
nickvergessen merged commit eb91d86 into masterJan 8, 2026
203 of 211 checks passed
@nickvergessen
nickvergessen deleted the fix/adjust-public-page-footer-logic branch January 8, 2026 10:10
@github-project-automationgithub-project-automationBot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware teamJan 8, 2026
@backportbot

This comment was marked as resolved.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbackport-request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianKrupinski@Antreesy@nickvergessen@come-nc