Skip to content

refactor: prepare Vue 3 migration - #55432

Merged
susnux merged 6 commits into
masterfrom
feat/vue3-demi-2
Oct 22, 2025
Merged

refactor: prepare Vue 3 migration#55432
susnux merged 6 commits into
masterfrom
feat/vue3-demi-2

Conversation

@susnux

@susnuxsusnux commented Sep 30, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  1. move legacy building to build/frontend-legacy (vue 2 apps)
  • apps are symlinked to be builded with webpack as before
  1. build script in root is now for Vue 3 apps
  2. migrated sharebymail as an example app.

Checklist

@susnuxsusnux added 2. developing Work in progress technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 30, 2025
@nextcloudnextcloud deleted a comment Sep 30, 2025
@nextcloudnextcloud deleted a comment Sep 30, 2025
come-nc
come-nc reviewed Sep 30, 2025
View reviewed changes
Comment threadlib/private/Template/CSSResourceLocator.php Outdated
come-nc
come-nc reviewed Sep 30, 2025
View reviewed changes
Comment threadlib/private/Template/JSResourceLocator.php
@susnux
susnux requested a review from come-ncOctober 1, 2025 11:51
@susnux
susnux marked this pull request as ready for review October 1, 2025 11:51
@susnux
susnux requested review from a team as code ownersOctober 1, 2025 11:51
@susnux
susnux requested review from ArtificialOwl, CarlSchwan, artonge, nfebe, skjnldsv and szaimen and removed request for a team and ArtificialOwlOctober 1, 2025 11:51
@susnuxsusnux added this to the Nextcloud 33 milestone Oct 1, 2025
@susnux
susnuxforce-pushed the feat/vue3-demi-2 branch 2 times, most recently from d33fadc to 384e5a4CompareOctober 1, 2025 12:07
szaimen
szaimen approved these changes Oct 1, 2025
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

artonge

This comment was marked as resolved.

Sign in to view

@susnuxsusnux mentioned this pull request Oct 2, 2025
Open
32 tasks
@susnux
susnuxforce-pushed the feat/vue3-demi-2 branch 6 times, most recently from 1521ad7 to 61ac440CompareOctober 21, 2025 13:11
@susnux
chore(Template): allow styles from dist folder
ab551c4
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

susnux commented Oct 22, 2025

Copy link
Copy Markdown
ContributorAuthor

The build files from both systems are ending up in the dist directory? Could there be some conflicts?

@artonge no because webpack uses .js and vite will create .mjs :)

@susnux
chore: split frontend building into legacy Vue 2 and Vue 3
f3383f9
- Built the frontend in separate packages until we migrated everything
to Vue 3.
- Separate logic into two packages controlled by main package.json
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: move icons building from core sources to build helpers
da5e279
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: adjust linter configs for new layout
3c1e9cd
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(sharebymail): migrate app to Vue 3
0ba4f52
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
9993f4e
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux marked this pull request as ready for review October 22, 2025 15:34
@susnux
susnux requested review from artonge and come-ncOctober 22, 2025 15:35
@susnux

susnux commented Oct 22, 2025

Copy link
Copy Markdown
ContributorAuthor

Basically nothing changed compared to before except that I split all complex side quests into other PRs that are now merged:

So this now only does a few things:

  • allow styles also from dist similar as with js assets
  • legacy apps are built in build/frontend-legacy with their dependencies
  • migrated apps are also built in build/frontend but the dependencies are already kept in the root for simpler switch once everything is migrated
  • Migrated first app (sharebymail) to Vue 3

How to migrate apps?

  1. Migrate the code to Vue 3
  2. Remove symlink from build/frontend-legacy/apps
  3. Remove entry from build/frontend-legacy/webpack.modules.cjs
  4. Add symlink to build/frontend/apps
  5. Add entry to build/frontend/vite.config.ts

@susnux
susnux merged commit 86e47d8 into masterOct 22, 2025
270 of 284 checks passed
@susnux
susnux deleted the feat/vue3-demi-2 branch October 22, 2025 20:07
@susnuxsusnux added 3. to review Waiting for reviews ❄️ 2026-Winter and removed 2. developing Work in progress labels Jan 5, 2026
@susnuxsusnux self-assigned this Jan 5, 2026
@github-project-automationgithub-project-automationBot moved this to 🏗️ In progress in 📁 Files teamJan 5, 2026
@susnuxsusnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files teamJan 5, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
@susnuxsusnux mentioned this pull request Jan 13, 2026
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@szaimenszaimenszaimen approved these changes
@artongeartongeAwaiting requested review from artonge
@come-nccome-ncAwaiting requested review from come-nc

Assignees

@susnuxsusnux

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)technical debt🧱 🤔🚀❄️ 2026-Winter

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@artonge@CarlSchwan@szaimen@come-nc