Skip to content

chore: Update @nextcloud/dialogs to v7.0.0 - #55726

Merged
susnux merged 4 commits into
masterfrom
chore/update-dialog-v7
Oct 15, 2025
Merged

chore: Update @nextcloud/dialogs to v7.0.0#55726
susnux merged 4 commits into
masterfrom
chore/update-dialog-v7

Conversation

@susnux

@susnuxsusnux commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Summary

This is the first step towards Vue 3.
As this package is a Vue version agnostic version of dialogs, written in Vue 3.

The huge changes count is related to the .license and .map files...

Checklist

@susnuxsusnux added this to the Nextcloud 33 milestone Oct 13, 2025
@susnuxsusnux added 3. to review Waiting for reviews dependencies labels Oct 13, 2025
@susnux
susnuxforce-pushed the chore/update-dialog-v7 branch from d31966c to be34bbeCompareOctober 13, 2025 20:57
This is the first step torwards Vue 3.
As this package is a Vue version agnostic version of dialogs, written in
Vue 3.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the chore/update-dialog-v7 branch 2 times, most recently from 29c9710 to 8ae5a8bCompareOctober 15, 2025 11:57
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux marked this pull request as ready for review October 15, 2025 12:25
@susnux
susnux requested review from a team and skjnldsv as code ownersOctober 15, 2025 12:25
@susnux
susnux requested review from nfebe and szaimen and removed request for a teamOctober 15, 2025 12:25
@susnux
susnuxforce-pushed the chore/update-dialog-v7 branch from 8ae5a8b to cc4f830CompareOctober 15, 2025 12:25
@susnux
susnux requested review from CarlSchwan and artonge and removed request for a teamOctober 15, 2025 12:25
@susnux
susnux enabled auto-merge October 15, 2025 13:50
})

it('Can move a file to its parent folder', () => {
it.only('Can move a file to its parent folder', () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove it?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followup: #55791

@susnux
susnux merged commit 65cdf14 into masterOct 15, 2025
146 of 151 checks passed
@susnux
susnux deleted the chore/update-dialog-v7 branch October 15, 2025 13:51
@max-nextcloud

Copy link
Copy Markdown
Contributor

It looks like this is breaking text CI. Is it expected that file picker button is not primary anymore?

failed-text-test

@susnux

Copy link
Copy Markdown
ContributorAuthor

@max-nextcloud no but that test in text is also not very good, you should not rely on class names.
Better to use roles (@testing-library/cypress with cy.findByRole('button', { name: 'Choose a.png' }))

@susnux

Copy link
Copy Markdown
ContributorAuthor

Fix for the primary regression: #55799

max-nextcloud added a commit that referenced this pull request Oct 18, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons
was deprecated and replaces with the `variant` prop.
In v9 the deprecated props are removed.
Use the `variant` prop in the deprecated `OC.dialogs`.
This is a follow up for #55726.
Signed-off-by: Max <max@nextcloud.com>
@susnuxsusnux mentioned this pull request Oct 22, 2025
6 tasks
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

susnux pushed a commit that referenced this pull request Dec 16, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons
was deprecated and replaces with the `variant` prop.
In v9 the deprecated props are removed.
Use the `variant` prop in the deprecated `OC.dialogs`.
This is a follow up for #55726.
Signed-off-by: Max <max@nextcloud.com>
susnux pushed a commit that referenced this pull request Dec 17, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttons
was deprecated and replaces with the `variant` prop.
In v9 the deprecated props are removed.
Use the `variant` prop in the deprecated `OC.dialogs`.
This is a follow up for #55726.
Signed-off-by: Max <max@nextcloud.com>
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@max-nextcloud@artonge@CarlSchwan