Uh oh!
There was an error while loading. Please reload this page.
fix(unified-search): Remove hard-coded search result limit - #55434
Merged
Conversation
nfebe
requested review from
ChristophWurst, artonge, nickvergessen, provokateurin, skjnldsv and susnuxSeptember 30, 2025 13:29
nfebe added a commit
that referenced
this pull request
Sep 30, 2025
We implemented a max entries per result config that ultimately hides possible search results after 25 (default) or configured maximum. This fix implements getting new entries starting from an offset with the allowed max entries. Related: #55434 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/unfied-search-pagination-limit
branch
from
October 1, 2025 11:10
649dbb3 to
a241675Compare
provokateurin
left a comment
Member
There was a problem hiding this comment.
Maybe just squash both commits, then the first commit won't introduce a possible issue.
Uh oh!
There was an error while loading. Please reload this page.
ChristophWurst
approved these changes
Oct 1, 2025
nfebeforce-pushed
the
fix/unfied-search-pagination-limit
branch
from
October 1, 2025 11:48
a241675 to
0ba46bcComparenfebeforce-pushed
the
fix/unfied-search-pagination-limit
branch
from
October 1, 2025 11:51
0ba46bc to
0384209Comparenfebe
enabled auto-merge
October 1, 2025 11:51
A change added in #45317 introduced a hard stop (25) that prevents full search results from showing up. If there are more than 25 search results for a query only 25 can be seen. So two main issues: - Only 25 results can be seen in total no matter what. - Breaks web client pagination, which typically adds 5 results per request. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/unfied-search-pagination-limit
branch
from
October 2, 2025 13:44
0384209 to
2053112Comparenfebe
commented
Oct 2, 2025
ContributorAuthor
cc: @provokateurin |
provokateurin
approved these changes
Oct 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
nfebe
commented
Oct 6, 2025
ContributorAuthor
/backport to stable32 |
nfebe
commented
Oct 6, 2025
ContributorAuthor
/backport to stable31 |
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55434/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 20531128
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55434/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in #45317 introduced a hard stop (25) that prevents full search results from showing up.
If there are more than 25 search results for a query only 25 can be seen.
So two main issues: