Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(unified-search): Remove hard-coded search result limit - #56344
Merged
Conversation
nfebe
enabled auto-merge
November 10, 2025 14:00
nfebe
requested review from
a team, icewind1991, leftybournes and yemkareems
and removed request for
a teamNovember 10, 2025 14:00
14 tasks
blizzz
approved these changes
Nov 12, 2025
blizzz
reviewed
Nov 12, 2025
Uh oh!
There was an error while loading. Please reload this page.
sorbaugh
approved these changes
Nov 13, 2025
A change added in #45317 introduced a hard stop (25) that prevents full search results from showing up. If there are more than 25 search results for a query only 25 can be seen. So two main issues: - Only 25 results can be seen in total no matter what. - Breaks web client pagination, which typically adds 5 results per request. Signed-off-by: nfebe <fenn25.fn@gmail.com>
provokateurinforce-pushed
the
backport/55434/stable31
branch
from
November 13, 2025 16:05
1341343 to
5d01642Compareprovokateurin
approved these changes
Nov 13, 2025
sorbaugh
disabled auto-merge
November 13, 2025 16:07
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #55434
A change added in #45317 introduced a hard stop (25) that prevents full search results from showing up.
If there are more than 25 search results for a query only 25 can be seen.
So two main issues: