Skip to content

chore: ensure no .only is commited in test files - #55791

Merged
susnux merged 1 commit into
masterfrom
chore/ensure-no-only
Oct 15, 2025
Merged

chore: ensure no .only is commited in test files#55791
susnux merged 1 commit into
masterfrom
chore/ensure-no-only

Conversation

@susnux

@susnuxsusnux commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Summary

.only is only to be used for development, but must not be committed. Instead failing tests which should be kept for later should be skipped (.skip).

Checklist

`.only` is only to be used for development, but must not be committed.
Instead failing tests which should be kept for later should be skipped
(`.skip`).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added this to the Nextcloud 33 milestone Oct 15, 2025
@susnuxsusnux added 3. to review Waiting for reviews tests Related to tests labels Oct 15, 2025
@susnux
susnux marked this pull request as ready for review October 15, 2025 14:01
@susnux
susnux requested review from a team as code ownersOctober 15, 2025 14:01
@susnux
susnux requested review from artonge, nfebe, skjnldsv and sorbaugh and removed request for a teamOctober 15, 2025 14:01

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@susnux
susnux merged commit 50f2874 into masterOct 15, 2025
157 of 167 checks passed
@susnux
susnux deleted the chore/ensure-no-only branch October 15, 2025 15:57
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstestsRelated to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@artonge@szaimen