Skip to content

fix(files_sharing): Hide 'Open locally' action - #55992

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
fauzanfebrian:fix/hide-open-locally-action
Nov 28, 2025
Merged

fix(files_sharing): Hide 'Open locally' action#55992
skjnldsv merged 1 commit into
nextcloud:masterfrom
fauzanfebrian:fix/hide-open-locally-action

Conversation

@fauzanfebrian

@fauzanfebrianfauzanfebrian commented Oct 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted.

This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior.

Resolves: #54970

  • Resolves: #

Summary

TODO

  • ...

Checklist

@fauzanfebrian
fauzanfebrian requested review from a team and skjnldsv as code ownersOctober 24, 2025 16:46
@fauzanfebrian
fauzanfebrian requested review from artonge and szaimen and removed request for a teamOctober 24, 2025 16:46
@fauzanfebrian

fauzanfebrian commented Oct 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Before
image

After
image

@skjnldsv

skjnldsv commented Oct 28, 2025

Copy link
Copy Markdown
Member

/backport to stable32

@skjnldsv

skjnldsv commented Oct 28, 2025

Copy link
Copy Markdown
Member

/backport to stable31 please

@skjnldsvskjnldsv self-assigned this Oct 28, 2025
@skjnldsvskjnldsv added this to the Nextcloud 33 milestone Oct 28, 2025
szaimen
szaimen approved these changes Oct 28, 2025
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsvskjnldsv mentioned this pull request Oct 28, 2025
Merged
@skjnldsv

skjnldsv commented Oct 28, 2025

Copy link
Copy Markdown
Member

Manual push for tests: #56060

@github-actions

github-actionsBot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@DaphneMuller

DaphneMuller commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

@skjnldsv@szaimen can this be merged?

@fauzanfebrian@skjnldsv
fix(files_sharing): Hide 'Open locally' action
a7509ae
This patch ensures that the "Open locally" context menu item is not
displayed for files in a share where the "download and sync" permission
has not been granted.
This prevents user confusion, as the action would fail anyway. The fix
adds a permission check before rendering the menu item, and adds a
corresponding unit test to verify this behavior.
Resolves: #54970
Signed-off-by: Fauzan <fauzanfebriann@gmail.com>
@skjnldsv

skjnldsv commented Nov 28, 2025

Copy link
Copy Markdown
Member

See #56060 for local branch

@skjnldsv
skjnldsv merged commit a7509ae into nextcloud:masterNov 28, 2025
179 of 225 checks passed
@fauzanfebrian
fauzanfebrian deleted the fix/hide-open-locally-action branch November 28, 2025 08:53
@fauzanfebrian
fauzanfebrian restored the fix/hide-open-locally-action branch November 28, 2025 08:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@szaimenszaimenszaimen approved these changes
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbackport-requestbugfeature: filesfeedback-requested

Projects

🧑‍🤝‍🧑 Community triage
Status: Done

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: "Open locally" shown for file in share without "download and sync" permission

4 participants

@fauzanfebrian@skjnldsv@DaphneMuller@szaimen