Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Hide 'Open locally' action - #56060
Merged
Merged
Conversation
skjnldsv
requested review from
artonge, sorbaugh and szaimen
and removed request for
a teamOctober 28, 2025 15:56
skjnldsv
commented
Oct 28, 2025
MemberAuthor
/compile |
skjnldsvforce-pushed
the
fix/hide-open-locally-action
branch
from
October 28, 2025 15:56
35b709b to
096047aCompare7 tasks
susnux
reviewed
Oct 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
susnux
reviewed
Oct 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted. This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior. Resolves: #54970 Signed-off-by: Fauzan <fauzanfebriann@gmail.com>
skjnldsvforce-pushed
the
fix/hide-open-locally-action
branch
from
November 28, 2025 07:55
3acce44 to
a7509aeCompareskjnldsv
commented
Nov 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsvforce-pushed
the
fix/hide-open-locally-action
branch
from
November 28, 2025 08:06
3637d8e to
0a4886eCompareSigned-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/hide-open-locally-action
branch
from
November 28, 2025 08:17
0a4886e to
478509aComparefauzanfebrian
approved these changes
Nov 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
commented
Nov 28, 2025
MemberAuthor
skjnldsv
commented
Nov 28, 2025
MemberAuthor
This was referenced Nov 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual push of #55992 from community
Closes#55992