Uh oh!
There was an error while loading. Please reload this page.
fix(encryption): Do not load encryption js on login - #56104
Closed
artonge wants to merge 1 commit into
Closed
Conversation
This was breaking ephemeral sessions again. Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
marked this pull request as ready for review
October 30, 2025 13:48
artonge
requested review from
icewind1991, leftybournes, salmart-dev and yemkareems
and removed request for
a teamOctober 30, 2025 13:48
artonge
commented
Oct 30, 2025
CollaboratorAuthor
/backport to stable32 |
artonge
commented
Oct 30, 2025
CollaboratorAuthor
/backport to stable31 |
artonge
commented
Nov 5, 2025
CollaboratorAuthor
Might be superfluous with #56215 |
artonge
marked this pull request as draft
November 5, 2025 12:47
artonge
commented
Nov 5, 2025
CollaboratorAuthor
Closing as the mentioned PR will be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was breaking ephemeral sessions again.
I am wondering if we should have an API to help loading those kinds of scripts. Like, most of the time, if I want to load a script outside a controller, then I want the login flow to be over, or I want to know which app is being loaded. Any opinion?