Skip to content

feat(EphemeralSessions): Introduce lax period - #56215

Merged
artonge merged 1 commit into
masterfrom
artonge/feat/ephemeral_lax_period
Nov 6, 2025
Merged

feat(EphemeralSessions): Introduce lax period#56215
artonge merged 1 commit into
masterfrom
artonge/feat/ephemeral_lax_period

Conversation

@artonge

Copy link
Copy Markdown
Collaborator

In an attempt to fix the numerous number of issues with ephemeral session, I suggest that we introduce a lax period of 60 seconds during which no request will close the session.

For the record, we had/have the following problematic requests:

@artongeartonge added this to the Nextcloud 33 milestone Nov 5, 2025
@artonge
artonge requested review from a team, come-nc and nickvergessenNovember 5, 2025 09:30
@artongeartonge self-assigned this Nov 5, 2025
@artongeartonge added enhancement 3. to review Waiting for reviews labels Nov 5, 2025
@artonge
artonge removed the request for review from a teamNovember 5, 2025 09:30
@artongeartonge added the php Pull requests that update Php code label Nov 5, 2025
@artonge
artongeforce-pushed the artonge/feat/ephemeral_lax_period branch from dd84951 to 9d458e6CompareNovember 5, 2025 12:57
@artonge
artonge requested a review from a team as a code ownerNovember 5, 2025 12:57
@nickvergessen

Copy link
Copy Markdown
Member

Other apps were:

  • guests
  • pride_flags
  • richdocuments
  • integration_youtube

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So first minute is good, but longer still runs into problems if it happens during the login flow?

I'm not sure we are overestimating peoples speed with passwords manager and 2FA auth a bit.

Should we bump the limit a bit higher to be "save"?

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

Should we bump the limit a bit higher to be "save"?

Yes, given that this feature only protects against leaving an open session behind, I think it is safe to bump it to 5 min.
1 min was the diplomatic middle ground :).

@artonge
artongeforce-pushed the artonge/feat/ephemeral_lax_period branch from 9d458e6 to 870d87bCompareNovember 5, 2025 14:30
Comment threadlib/private/Authentication/Login/FlowV2EphemeralSessionsCommand.php Outdated
@artonge
artongeforce-pushed the artonge/feat/ephemeral_lax_period branch 2 times, most recently from 337feed to 1fd089cCompareNovember 5, 2025 15:07
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge
artongeforce-pushed the artonge/feat/ephemeral_lax_period branch from 1fd089c to ed4a170CompareNovember 5, 2025 15:08
@artonge
artonge merged commit 4850e54 into masterNov 6, 2025
198 of 200 checks passed
@artonge
artonge deleted the artonge/feat/ephemeral_lax_period branch November 6, 2025 10:24
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable32

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable31

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable29

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable27

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable26

@artonge

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable25

@jumasamson7531-hash

This comment was marked as spam.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementfeature: authenticationphpPull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@nickvergessen@jumasamson7531-hash@CarlSchwan