Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(files_sharing): Hide 'Open locally' action - #56737
Merged
Conversation
This patch ensures that the "Open locally" context menu item is not displayed for files in a share where the "download and sync" permission has not been granted. This prevents user confusion, as the action would fail anyway. The fix adds a permission check before rendering the menu item, and adds a corresponding unit test to verify this behavior. Resolves: #54970 Signed-off-by: Fauzan <fauzanfebriann@gmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com> [skip ci]
skjnldsvforce-pushed
the
backport/56060/stable31
branch
from
November 28, 2025 08:54
37d89ce to
9da57f6Compareskjnldsv
commented
Nov 28, 2025
Member
/compile |
skjnldsv
marked this pull request as ready for review
November 28, 2025 08:55
skjnldsv
approved these changes
Nov 28, 2025
skjnldsv
requested review from
a team, nfebe, sorbaugh and susnux
and removed request for
a teamNovember 28, 2025 08:55
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Nov 29, 2025
AndyScherzinger
approved these changes
Nov 29, 2025
AndyScherzinger
enabled auto-merge
November 29, 2025 06:36
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #56060
Warning, This backport had conflicts that were resolved with the⚠️
oursmerge strategy and is likely incompleteTodo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.