Skip to content

Share mount validation fixes - #57745

Merged
icewind1991 merged 3 commits into
masterfrom
share-transfered-event
Feb 9, 2026
Merged

Share mount validation fixes#57745
icewind1991 merged 3 commits into
masterfrom
share-transfered-event

Conversation

@icewind1991

@icewind1991icewind1991 commented Jan 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • For transfered shares we might need to re-perform share target validation.
  • The "only refresh shares once per user per request" optimization seems to be overeager, breaks some cases and needs to be reworked.

@icewind1991icewind1991 added this to the Nextcloud 34 milestone Jan 22, 2026
@icewind1991
icewind1991 requested a review from a team as a code ownerJanuary 22, 2026 18:16
@icewind1991
icewind1991 removed the request for review from a teamJanuary 22, 2026 18:16
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 22, 2026
@icewind1991icewind1991 changed the title feat: add event for tranfered sharesShare mount validation fixesJan 22, 2026
@icewind1991icewind1991 mentioned this pull request Jan 22, 2026
Merged
4 tasks
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 22, 2026
@nickvergessen
test: Run tests againstnextcloud/server#57745"Share mount validatio…
9067690
…n fixes"
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen mentioned this pull request Jan 22, 2026
Closed
@icewind1991
icewind1991force-pushed the share-transfered-event branch from b3fc17e to 858b058CompareJanuary 22, 2026 19:31
@artongeartonge mentioned this pull request Jan 23, 2026
Open
@nickvergessen

nickvergessen commented Jan 27, 2026

Copy link
Copy Markdown
Member

Is the failing files_drop test related?

Could not open file: drop/Alice/folder/a.txt (214), file does seem to exist

@artongeartonge mentioned this pull request Jan 29, 2026
Merged
@icewind1991
feat: add event for tranfered shares
c49665f
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: remove validate-user-shares-once optimization
3b70d0f
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: prevent recursion in SharesUpdatedListener
9c10593
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the share-transfered-event branch from 48a23fe to 9c10593CompareFebruary 6, 2026 15:55
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 7, 2026
@nickvergessen
test: Run tests fornextcloud/server#57745"share-transfered-event"
eb76608
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen mentioned this pull request Feb 7, 2026
Closed
nickvergessen
nickvergessen approved these changes Feb 9, 2026
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the currently red tests in Talk

@icewind1991
icewind1991 merged commit 9cd337b into masterFeb 9, 2026
197 of 199 checks passed
@icewind1991
icewind1991 deleted the share-transfered-event branch February 9, 2026 15:46
@icewind1991icewind1991 mentioned this pull request Mar 12, 2026
Merged
1 task
@artongeartonge mentioned this pull request Mar 24, 2026
Merged
1 task
@nextcloud-botnextcloud-bot mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@artongeartongeAwaiting requested review from artonge

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@nickvergessen@CarlSchwan