Skip to content

[stable33] authoritative share - revival - #59177

Merged
sorbaugh merged 17 commits into
stable33from
revert-59172-revert-58894-stable33-authoritative-share
Apr 28, 2026
Merged

[stable33] authoritative share - revival#59177
sorbaugh merged 17 commits into
stable33from
revert-59172-revert-58894-stable33-authoritative-share

Conversation

@artonge

@artongeartonge commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

@artonge
artonge requested a review from a team as a code ownerMarch 24, 2026 17:24
@artonge
artonge requested review from ArtificialOwl, come-nc, icewind1991 and salmart-dev and removed request for a teamMarch 24, 2026 17:24
@artongeartonge added the 2. developing Work in progress label Mar 24, 2026
@artongeartonge added this to the Nextcloud 33.0.2 milestone Mar 24, 2026
@artonge

Copy link
Copy Markdown
CollaboratorAuthor

Adding Arthur's comment

image

@blizzz

Copy link
Copy Markdown
Member

@blizzzblizzz added the pending documentation This pull request needs an associated documentation update label Mar 24, 2026
This was referenced Mar 27, 2026
@icewind1991
icewind1991force-pushed the revert-59172-revert-58894-stable33-authoritative-share branch 2 times, most recently from 954515d to 2da22ebCompareApril 9, 2026 16:45
@icewind1991

Copy link
Copy Markdown
Member

Added backport of #58207

@icewind1991
icewind1991force-pushed the revert-59172-revert-58894-stable33-authoritative-share branch 7 times, most recently from 6e479b9 to 3248ac3CompareApril 14, 2026 20:10
@nextcloud-botnextcloud-bot mentioned this pull request Apr 20, 2026
@icewind1991
icewind1991force-pushed the revert-59172-revert-58894-stable33-authoritative-share branch from 2296e52 to 8e0880eCompareApril 21, 2026 14:22

// after the mountpoint is verified for the first time, only new mountpoints (e.g. groupfolders can overwrite the target)
if ($shareId > $maxValidatedShare || isset($allMounts[$absMountPoint])) {
$this->shareTargetValidator->verifyMountPoint($user, $parentShare, $allMounts, $groupedShares);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a bit of a problem with removing this from here: when a room or deck shares are created and during the recipients' mounts update or any other call we end up calling setupForUser or setupForProvider, which resolve the share with the target containing the placeholder. This logic before was patching the target through the moveShare call performed down the line because of the updated target.

Not sure what a fix for those would be, besides having talk and deck proactively creating a user-row for shares when they are queried for a recipient. It shouldn't be a big deal since anyways this was done whenever verifyMountPoint was called the first time.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When explicitly triggering this case with 'debug.force-full-fs-setup' => true, 'debug.optimize-authoritative-providers' => false. It does indeed register a {TALK_PLACEHOLDER} mountpoint during the fs setup, but this then immediately gets fixed by ShareTargetValidator::updateFileTarget

@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Apr 27, 2026
artongeand others added 17 commits April 28, 2026 15:49
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…d on create
Signed-off-by: Robin Appelman <robin@icewind.nl>
…licts
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…d on validate
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
@icewind1991
icewind1991force-pushed the revert-59172-revert-58894-stable33-authoritative-share branch from bb3d989 to 88134bcCompareApril 28, 2026 13:50
@sorbaugh
sorbaugh merged commit 84e2ebe into stable33Apr 28, 2026
176 of 181 checks passed
@sorbaugh
sorbaugh deleted the revert-59172-revert-58894-stable33-authoritative-share branch April 28, 2026 13:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewspending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@artonge@blizzz@icewind1991@salmart-dev@sorbaugh@joshtrichards@tobiasKaminsky