Uh oh!
There was an error while loading. Please reload this page.
[stable33] authoritative share - revival - #59177
Conversation
artonge
commented
Mar 24, 2026
blizzz
commented
Mar 24, 2026
Thanks! Additionally, those changes need to go be added to https://github.com/nextcloud/documentation/blob/master/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_33.rst respecitvely https://github.com/nextcloud/documentation/blob/master/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_34.rst I am already adding the pending docs label. |
954515d to
2da22ebCompareicewind1991
commented
Apr 9, 2026
Added backport of #58207 |
6e479b9 to
3248ac3Compare2296e52 to
8e0880eCompare| // after the mountpoint is verified for the first time, only new mountpoints (e.g. groupfolders can overwrite the target) | ||
| if ($shareId > $maxValidatedShare || isset($allMounts[$absMountPoint])) { | ||
| $this->shareTargetValidator->verifyMountPoint($user, $parentShare, $allMounts, $groupedShares); |
There was a problem hiding this comment.
There is still a bit of a problem with removing this from here: when a room or deck shares are created and during the recipients' mounts update or any other call we end up calling setupForUser or setupForProvider, which resolve the share with the target containing the placeholder. This logic before was patching the target through the moveShare call performed down the line because of the updated target.
Not sure what a fix for those would be, besides having talk and deck proactively creating a user-row for shares when they are queried for a recipient. It shouldn't be a big deal since anyways this was done whenever verifyMountPoint was called the first time.
There was a problem hiding this comment.
When explicitly triggering this case with 'debug.force-full-fs-setup' => true, 'debug.optimize-authoritative-providers' => false. It does indeed register a {TALK_PLACEHOLDER} mountpoint during the fs setup, but this then immediately gets fixed by ShareTargetValidator::updateFileTarget
Signed-off-by: Louis <louis@chmn.me>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…d on create Signed-off-by: Robin Appelman <robin@icewind.nl>
…licts Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…d on validate Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
bb3d989 to
88134bcCompareUh oh!
There was an error while loading. Please reload this page.

Reverts #59172 to have a PR for #58894 again.
Backports of