Active share validation/authoritative mount improvements

[icewind1991]

• For events where we know the share, only check/register mount for that share
• Above a certain number of users, postpone the checks till fs setup time for the user

[icewind1991]

#59177 has the stable33 backport

[DerDreschner]

@icewind1991: I see different InvalidPartitionedQueryException in the CI runs that seem to be related to your changes here according to the stack-trace. Could you check if those exception is valid and break things...? I have the feeling that our flaky tests may be associated with it. Plan to do #62087 to prevent something like this in the future (if this is valid).

Example error message from one of our CI runs

{
"reqId":"yEEv7M5ICGSSJJQf4XWh",
"level":3,
"time":"2026-07-14T07:29:53+00:00",
"remoteAddr":"",
"user":"test-share-user2",
"app":"no app in context",
"method":"",
"url":"--",
"scriptName":"/home/runner/actions-runner/_work/server/server/lib/composer/bin/phpunit",
"message":"Error while sending 'share created' event",
"userAgent":"--",
"version":"35.0.0.1",
"occ_command":[
"/home/runner/actions-runner/_work/server/server/lib/composer/bin/phpunit",
"--fail-on-warning"
],
"exception":{
"Exception":"OC\\DB\\QueryBuilder\\Partitioned\\InvalidPartitionedQueryException",
"Message":"Limit is not allowed in partitioned queries",
"Code":0,
"Trace":[
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/Files/Config/UserMountCache.php",
"line":635,
"function":"executeQuery",
"class":"OC\\DB\\QueryBuilder\\Partitioned\\PartitionedQueryBuilder",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareRecipientUpdater.php",
"line":77,
"function":"getMountAtPath",
"class":"OC\\Files\\Config\\UserMountCache",
"type":"->",
"args":[
"*** sensitive parameters replaced ***",
"*** sensitive parameters replaced ***"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php",
"line":143,
"function":"{closure:OCA\\Files_Sharing\\ShareRecipientUpdater::updateForAddedShare():77}",
"class":"OCA\\Files_Sharing\\ShareRecipientUpdater",
"type":"->",
"args":[
"*** sensitive parameters replaced ***"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php",
"line":130,
"function":"hasConflictingMount",
"class":"OCA\\Files_Sharing\\ShareTargetValidator",
"type":"->",
"args":[
2649857,
{
"__class__":"Closure"
},
"/test-share-user4/files/directReshare"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php",
"line":93,
"function":"generateUniqueTarget",
"class":"OCA\\Files_Sharing\\ShareTargetValidator",
"type":"->",
"args":[
2649857,
"/test-share-user4/files/directReshare",
{
"__class__":"OC\\Files\\Mount\\HomeMountPoint"
},
{
"__class__":"Closure"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareRecipientUpdater.php",
"line":77,
"function":"verifyMountPoint",
"class":"OCA\\Files_Sharing\\ShareTargetValidator",
"type":"->",
"args":[
"*** sensitive parameters replaced ***",
"*** sensitive parameters replaced ***",
{
"__class__":"Closure"
},
[
"*** sensitive parameters replaced ***"
]
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php",
"line":98,
"function":"updateForAddedShare",
"class":"OCA\\Files_Sharing\\ShareRecipientUpdater",
"type":"->",
"args":[
"*** sensitive parameters replaced ***"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php",
"line":138,
"function":"{closure:OCA\\Files_Sharing\\Listener\\SharesUpdatedListener::handle():97}",
"class":"OCA\\Files_Sharing\\Listener\\SharesUpdatedListener",
"type":"->",
"args":[
"*** sensitive parameters replaced ***"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php",
"line":97,
"function":"markOrRun",
"class":"OCA\\Files_Sharing\\Listener\\SharesUpdatedListener",
"type":"->",
"args":[
"*** sensitive parameters replaced ***",
{
"__class__":"Closure"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/ServiceEventListener.php",
"line":57,
"function":"handle",
"class":"OCA\\Files_Sharing\\Listener\\SharesUpdatedListener",
"type":"->",
"args":[
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
"line":220,
"function":"__invoke",
"class":"OC\\EventDispatcher\\ServiceEventListener",
"type":"->",
"args":[
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
},
"OCP\\Share\\Events\\ShareCreatedEvent",
{
"__class__":"Symfony\\Component\\EventDispatcher\\EventDispatcher"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
"line":56,
"function":"callListeners",
"class":"Symfony\\Component\\EventDispatcher\\EventDispatcher",
"type":"->",
"args":[
[
{
"__class__":"Closure"
},
{
"__class__":"Closure"
},
{
"__class__":"Closure"
},
{
"__class__":"Closure"
},
{
"__class__":"Closure"
},
"And 8 more entries, set log level to debug to see all entries"
],
"OCP\\Share\\Events\\ShareCreatedEvent",
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php",
"line":74,
"function":"dispatch",
"class":"Symfony\\Component\\EventDispatcher\\EventDispatcher",
"type":"->",
"args":[
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
},
"OCP\\Share\\Events\\ShareCreatedEvent"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php",
"line":87,
"function":"dispatch",
"class":"OC\\EventDispatcher\\EventDispatcher",
"type":"->",
"args":[
"OCP\\Share\\Events\\ShareCreatedEvent",
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php",
"line":1895,
"function":"dispatchTyped",
"class":"OC\\EventDispatcher\\EventDispatcher",
"type":"->",
"args":[
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php",
"line":635,
"function":"dispatchEvent",
"class":"OC\\Share20\\Manager",
"type":"->",
"args":[
{
"__class__":"OCP\\Share\\Events\\ShareCreatedEvent"
},
"share created"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/EtagPropagationTest.php",
"line":138,
"function":"createShare",
"class":"OC\\Share20\\Manager",
"type":"->",
"args":[
"*** sensitive parameters replaced ***"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/PropagationTestCase.php",
"line":33,
"function":"setUpShares",
"class":"OCA\\Files_Sharing\\Tests\\EtagPropagationTest",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php",
"line":2467,
"function":"setUp",
"class":"OCA\\Files_Sharing\\Tests\\PropagationTestCase",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php",
"line":2370,
"function":"invokeHookMethods",
"class":"PHPUnit\\Framework\\TestCase",
"type":"->",
"args":[
{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
{
"__class__":"PHPUnit\\Event\\DispatchingEmitter"
},
"beforeTestMethodCalled",
"beforeTestMethodErrored",
"beforeTestMethodFinished"
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php",
"line":511,
"function":"invokeBeforeTestHookMethods",
"class":"PHPUnit\\Framework\\TestCase",
"type":"->",
"args":[
{
"beforeClass":{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
"before":{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
"preCondition":{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
"postCondition":{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
"after":{
"__class__":"PHPUnit\\Runner\\HookMethodCollection"
},
"0":"And 1 more entries, set log level to debug to see all entries"
},
{
"__class__":"PHPUnit\\Event\\DispatchingEmitter"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/php-invoker/src/Invoker.php",
"line":55,
"function":"runBare",
"class":"PHPUnit\\Framework\\TestCase",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestRunner/TestRunner.php",
"line":311,
"function":"invoke",
"class":"SebastianBergmann\\Invoker\\Invoker",
"type":"->",
"args":[
[
{
"__class__":"OCA\\Files_Sharing\\Tests\\EtagPropagationTest",
"filename":null,
"data":"foobar",
"view":{
"__class__":"OC\\Files\\View"
},
"view2":{
"__class__":"OC\\Files\\View"
},
"folder":null,
"subfolder":null
},
"runBare"
],
[
],
300
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestRunner/TestRunner.php",
"line":85,
"function":"runTestWithTimeout",
"class":"PHPUnit\\Framework\\TestRunner",
"type":"->",
"args":[
{
"__class__":"OCA\\Files_Sharing\\Tests\\EtagPropagationTest",
"filename":null,
"data":"foobar",
"view":{
"__class__":"OC\\Files\\View"
},
"view2":{
"__class__":"OC\\Files\\View"
},
"folder":null,
"subfolder":null
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php",
"line":365,
"function":"run",
"class":"PHPUnit\\Framework\\TestRunner",
"type":"->",
"args":[
{
"__class__":"OCA\\Files_Sharing\\Tests\\EtagPropagationTest",
"filename":null,
"data":"foobar",
"view":{
"__class__":"OC\\Files\\View"
},
"view2":{
"__class__":"OC\\Files\\View"
},
"folder":null,
"subfolder":null
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php",
"line":369,
"function":"run",
"class":"PHPUnit\\Framework\\TestCase",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php",
"line":369,
"function":"run",
"class":"PHPUnit\\Framework\\TestSuite",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php",
"line":369,
"function":"run",
"class":"PHPUnit\\Framework\\TestSuite",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/TextUI/TestRunner.php",
"line":64,
"function":"run",
"class":"PHPUnit\\Framework\\TestSuite",
"type":"->",
"args":[
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/TextUI/Application.php",
"line":211,
"function":"run",
"class":"PHPUnit\\TextUI\\TestRunner",
"type":"->",
"args":[
{
"__class__":"PHPUnit\\TextUI\\Configuration\\Configuration"
},
{
"__class__":"PHPUnit\\Runner\\ResultCache\\DefaultResultCache"
},
{
"__class__":"PHPUnit\\Framework\\TestSuite"
}
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/phpunit",
"line":104,
"function":"run",
"class":"PHPUnit\\TextUI\\Application",
"type":"->",
"args":[
[
"/home/runner/actions-runner/_work/server/server/lib/composer/bin/phpunit",
"--fail-on-warning",
"--fail-on-risky",
"--display-warnings",
"--display-deprecations",
"And 19 more entries, set log level to debug to see all entries"
]
]
},
{
"file":"/home/runner/actions-runner/_work/server/server/lib/composer/bin/phpunit",
"line":122,
"args":[
"/home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/phpunit"
],
"function":"include"
}
],
"File":"/home/runner/actions-runner/_work/server/server/lib/private/DB/QueryBuilder/Partitioned/PartitionedQueryBuilder.php",
"Line":436,
"message":"Error while sending 'share created' event",
"exception":"{\"class\":\"OC\\DB\\QueryBuilder\\Partitioned\\InvalidPartitionedQueryException\",\"message\":\"Limit is not allowed in partitioned queries\",\"code\":0,\"file\":\"/home/runner/actions-runner/_work/server/server/lib/private/DB/QueryBuilder/Partitioned/PartitionedQueryBuilder.php:436\",\"trace\":\"#0 /home/runner/actions-runner/_work/server/server/lib/private/Files/Config/UserMountCache.php(635): OC\\DB\\QueryBuilder\\Partitioned\\PartitionedQueryBuilder->executeQuery()\\n#1 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareRecipientUpdater.php(77): OC\\Files\\Config\\UserMountCache->getMountAtPath(Object(OC\\User\\LazyUser), '/test-share-use...')\\n#2 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php(143): OCA\\Files_Sharing\\ShareRecipientUpdater->{closure:OCA\\Files_Sharing\\ShareRecipientUpdater::updateForAddedShare():77}('/test-share-use...')\\n#3 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php(130): OCA\\Files_Sharing\\ShareTargetValidator->hasConflictingMount(2649857, Object(Closure), '/test-share-use...')\\n#4 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareTargetValidator.php(93): OCA\\Files_Sharing\\ShareTargetValidator->generateUniqueTarget(2649857, '/test-share-use...', Object(OC\\Files\\Mount\\HomeMountPoint), Object(Closure))\\n#5 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/ShareRecipientUpdater.php(77): OCA\\Files_Sharing\\ShareTargetValidator->verifyMountPoint(Object(OC\\User\\LazyUser), Object(OC\\Share20\\Share), Object(Closure), Array)\\n#6 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php(98): OCA\\Files_Sharing\\ShareRecipientUpdater->updateForAddedShare(Object(OC\\User\\LazyUser), Object(OC\\Share20\\Share))\\n#7 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php(138): OCA\\Files_Sharing\\Listener\\SharesUpdatedListener->{closure:OCA\\Files_Sharing\\Listener\\SharesUpdatedListener::handle():97}()\\n#8 /home/runner/actions-runner/_work/server/server/apps/files_sharing/lib/Listener/SharesUpdatedListener.php(97): OCA\\Files_Sharing\\Listener\\SharesUpdatedListener->markOrRun(Object(OC\\User\\LazyUser), Object(Closure))\\n#9 /home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/ServiceEventListener.php(57): OCA\\Files_Sharing\\Listener\\SharesUpdatedListener->handle(Object(OCP\\Share\\Events\\ShareCreatedEvent))\\n#10 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php(220): OC\\EventDispatcher\\ServiceEventListener->__invoke(Object(OCP\\Share\\Events\\ShareCreatedEvent), 'OCP\\\\Share\\\\Event...', Object(Symfony\\Component\\EventDispatcher\\EventDispatcher))\\n#11 /home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php(56): Symfony\\Component\\EventDispatcher\\EventDispatcher->callListeners(Array, 'OCP\\\\Share\\\\Event...', Object(OCP\\Share\\Events\\ShareCreatedEvent))\\n#12 /home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php(74): Symfony\\Component\\EventDispatcher\\EventDispatcher->dispatch(Object(OCP\\Share\\Events\\ShareCreatedEvent), 'OCP\\\\Share\\\\Event...')\\n#13 /home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php(87): OC\\EventDispatcher\\EventDispatcher->dispatch('OCP\\\\Share\\\\Event...', Object(OCP\\Share\\Events\\ShareCreatedEvent))\\n#14 /home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php(1895): OC\\EventDispatcher\\EventDispatcher->dispatchTyped(Object(OCP\\Share\\Events\\ShareCreatedEvent))\\n#15 /home/runner/actions-runner/_work/server/server/lib/private/Share20/Manager.php(635): OC\\Share20\\Manager->dispatchEvent(Object(OCP\\Share\\Events\\ShareCreatedEvent), 'share created')\\n#16 /home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/EtagPropagationTest.php(138): OC\\Share20\\Manager->createShare(Object(OC\\Share20\\Share))\\n#17 /home/runner/actions-runner/_work/server/server/apps/files_sharing/tests/PropagationTestCase.php(33): OCA\\Files_Sharing\\Tests\\EtagPropagationTest->setUpShares()\\n#18 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php(2467): OCA\\Files_Sharing\\Tests\\PropagationTestCase->setUp()\\n#19 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php(2370): PHPUnit\\Framework\\TestCase->invokeHookMethods(Object(PHPUnit\\Runner\\HookMethodCollection), Object(PHPUnit\\Event\\DispatchingEmitter), 'beforeTestMetho...', 'beforeTestMetho...', 'beforeTestMetho...')\\n#20 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php(511): PHPUnit\\Framework\\TestCase->invokeBeforeTestHookMethods(Array, Object(PHPUnit\\Event\\DispatchingEmitter))\\n#21 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/php-invoker/src/Invoker.php(55): PHPUnit\\Framework\\TestCase->runBare()\\n#22 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestRunner/TestRunner.php(311): SebastianBergmann\\Invoker\\Invoker->invoke(Array, Array, 300)\\n#23 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestRunner/TestRunner.php(85): PHPUnit\\Framework\\TestRunner->runTestWithTimeout(Object(OCA\\Files_Sharing\\Tests\\EtagPropagationTest))\\n#24 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestCase.php(365): PHPUnit\\Framework\\TestRunner->run(Object(OCA\\Files_Sharing\\Tests\\EtagPropagationTest))\\n#25 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php(369): PHPUnit\\Framework\\TestCase->run()\\n#26 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php(369): PHPUnit\\Framework\\TestSuite->run()\\n#27 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/Framework/TestSuite.php(369): PHPUnit\\Framework\\TestSuite->run()\\n#28 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(64): PHPUnit\\Framework\\TestSuite->run()\\n#29 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/src/TextUI/Application.php(211): PHPUnit\\TextUI\\TestRunner->run(Object(PHPUnit\\TextUI\\Configuration\\Configuration), Object(PHPUnit\\Runner\\ResultCache\\DefaultResultCache), Object(PHPUnit\\Framework\\TestSuite))\\n#30 /home/runner/actions-runner/_work/server/server/vendor-bin/behat/vendor/phpunit/phpunit/phpunit(104): PHPUnit\\TextUI\\Application->run(Array)\\n#31 /home/runner/actions-runner/_work/server/server/lib/composer/bin/phpunit(122): include('/home/runner/ac...')\\n#32 {main}\"}",
"CustomMessage":"Error while sending 'share created' event"
}
}