Skip to content

refactor(QueryBuilder): Properly type the query builder - #57763

Open
CarlSchwan wants to merge 2 commits into
masterfrom
carl/type-querybuilder
Open

refactor(QueryBuilder): Properly type the query builder#57763
CarlSchwan wants to merge 2 commits into
masterfrom
carl/type-querybuilder

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

TODO

  • ...

Checklist

@CarlSchwanCarlSchwan added this to the Nextcloud 34 milestone Jan 23, 2026
@CarlSchwanCarlSchwan self-assigned this Jan 23, 2026
@CarlSchwanCarlSchwan added 2. developing Work in progress feature: database Database related DB labels Jan 23, 2026
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jan 23, 2026
View reviewed changes
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Fixed
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch 7 times, most recently from 4949aa8 to 27c24e9CompareJanuary 26, 2026 10:02
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jan 26, 2026
View reviewed changes
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Fixed
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch 2 times, most recently from 75af4a1 to ca05129CompareJanuary 27, 2026 10:17
@CarlSchwanCarlSchwan added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 27, 2026
@CarlSchwan
CarlSchwan marked this pull request as ready for review January 27, 2026 10:18
@CarlSchwan
CarlSchwan requested review from Altahrim, ArtificialOwl, icewind1991 and sorbaugh and removed request for a teamJanuary 27, 2026 10:18
come-nc
come-nc reviewed Jan 27, 2026
View reviewed changes
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Comment threadlib/private/DB/QueryBuilder/Sharded/ShardedQueryBuilder.php
Comment threadlib/public/DB/QueryBuilder/IFunctionBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch 3 times, most recently from efaca86 to 4020f91CompareJanuary 30, 2026 14:28
provokateurin
provokateurin requested changes Feb 17, 2026
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all files you touched to psalm:strict and rector:strict. That will probably result in some more issues being found, but I think it's worth fixing them in such an important part of our codebase.

Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch from 4020f91 to 5c85223CompareFebruary 25, 2026 11:07
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@CarlSchwan
refactor(QueryBuilder): Properly type the query builder
a6a7c2f
And make sure the related unit tests are also typed and checked by
psalm.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch from 5c85223 to d5b81a1CompareJune 23, 2026 10:36
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch from d5b81a1 to bbaf603CompareJune 23, 2026 11:35
@CarlSchwan
fix(QueryBuilder): Make types even more strict
fa0d136
And put the files in rector strict and psalm strict
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwanforce-pushed the carl/type-querybuilder branch from bbaf603 to fa0d136CompareJune 23, 2026 11:37
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jun 23, 2026
View reviewed changes
Comment threadlib/public/DB/QueryBuilder/IQueryBuilder.php Dismissed
@CarlSchwanCarlSchwan mentioned this pull request Jun 23, 2026
Merged
7 tasks
come-nc
come-nc approved these changes Jun 23, 2026
View reviewed changes
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
* SPDX-License-Identifier: AGPL-3.0-only
*/

declare(strict_types=1);

@come-nccome-ncJun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be above license

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nccome-nccome-nc approved these changes
@hamza221hamza221Awaiting requested review from hamza221hamza221 is a code owner
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinskiSebastianKrupinski is a code owner
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurin

Requested changes must be addressed to merge this pull request.

Assignees

@CarlSchwanCarlSchwan

Labels

3. to reviewWaiting for reviewsfeature: databaseDatabase related DB

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

7 participants

@CarlSchwan@provokateurin@github-advanced-security@come-nc@joshtrichards@susnux@nextcloud-bot