Skip to content

feat: Add support for NOT ILIKE in query builder expressions - #61521

Merged
AndyScherzinger merged 1 commit into
masterfrom
feature/add-not-i-like-to-query-builder
Jul 3, 2026
Merged

feat: Add support for NOT ILIKE in query builder expressions#61521
AndyScherzinger merged 1 commit into
masterfrom
feature/add-not-i-like-to-query-builder

Conversation

@Koc

@KocKoc commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

We already have like, notLike, iLike. Let's add also notILike to have full set of the operations

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Koc
Koc requested a review from a team as a code ownerJune 22, 2026 22:10
@Koc
Koc requested review from Altahrim, ArtificialOwl, come-nc and icewind1991 and removed request for a teamJune 22, 2026 22:10
CarlSchwan
CarlSchwan approved these changes Jun 23, 2026
View reviewed changes

@CarlSchwanCarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In preparation for #57763

Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/MySqlExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/MySqlExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/PgSqlExpressionBuilder.php Outdated
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/SqliteExpressionBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IExpressionBuilder.php Outdated
Comment threadlib/public/DB/QueryBuilder/IExpressionBuilder.php Outdated
@Koc
Kocforce-pushed the feature/add-not-i-like-to-query-builder branch 3 times, most recently from fd53198 to 0a7ac5dCompareJune 23, 2026 20:18
@Koc

Koc commented Jun 23, 2026

Copy link
Copy Markdown
ContributorAuthor

@CarlSchwan I've applied changes but now psalm fails 😕

@susnuxsusnux added the community pull requests from community label Jun 24, 2026
@Koc
Kocforce-pushed the feature/add-not-i-like-to-query-builder branch 2 times, most recently from 392e3f4 to 727772cCompareJune 24, 2026 08:33
@Koc

Koc commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

Psalm fixed. Current test failures looks unrelated to my changes

@Koc
Kocforce-pushed the feature/add-not-i-like-to-query-builder branch from 727772c to 29842d5CompareJune 27, 2026 12:14
come-nc
come-nc reviewed Jun 29, 2026
View reviewed changes
Comment threadlib/private/DB/QueryBuilder/ExpressionBuilder/MySqlExpressionBuilder.php
@Koc
Kocforce-pushed the feature/add-not-i-like-to-query-builder branch from 29842d5 to 6674f25CompareJune 30, 2026 12:08
@Koc

Koc commented Jun 30, 2026

Copy link
Copy Markdown
ContributorAuthor

there are 2 approvals, nice!
But I still can't merge because of unrelated pipeline failures. Can you assist, @come-nc@CarlSchwan ? 🙏

@come-nccome-nc added the 3. to review Waiting for reviews label Jun 30, 2026
@come-nccome-nc added this to the Nextcloud 35 milestone Jun 30, 2026
@come-nc
come-ncforce-pushed the feature/add-not-i-like-to-query-builder branch from 6674f25 to e89d0ceCompareJune 30, 2026 15:31
@Koc
feat: Add support for NOT ILIKE in query builder expressions
ae34345
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Kocforce-pushed the feature/add-not-i-like-to-query-builder branch from e89d0ce to ae34345CompareJuly 3, 2026 07:53
@AndyScherzinger
AndyScherzinger merged commit ed59259 into masterJul 3, 2026
194 of 196 checks passed
@AndyScherzinger
AndyScherzinger deleted the feature/add-not-i-like-to-query-builder branch July 3, 2026 10:49
@KocKoc mentioned this pull request Jul 18, 2026
Open
5 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewscommunitypull requests from community

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@Koc@CarlSchwan@come-nc@AndyScherzinger@susnux