Skip to content

refactor(appstore): split appstore from settings app - #59997

Merged
sorbaugh merged 5 commits into
masterfrom
chore/split-appstore
May 5, 2026
Merged

refactor(appstore): split appstore from settings app#59997
sorbaugh merged 5 commits into
masterfrom
chore/split-appstore

Conversation

@susnux

@susnuxsusnux commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

See #57290 for details.
This only contains the app split and the needed changes to make it work in a separate app.
Moreover this also applies strict rector rules, for this I needed to fix a bug where rector (and also for psalm strict) did not have access to OCP (lib/public) and thus did not knew about those classes / interfaces and produced wrong output.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnuxsusnux added this to the Nextcloud 34 milestone Apr 29, 2026
@susnux
susnux requested review from a team and provokateurin as code ownersApril 29, 2026 19:57
@susnuxsusnux added the 3. to review Waiting for reviews label Apr 29, 2026
@susnux
susnux requested a review from a team as a code ownerApril 29, 2026 19:57
@susnuxsusnux added technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 29, 2026
@susnux
susnux requested review from CarlSchwan, leftybournes, nfebe, salmart-dev, sorbaugh and szaimen and removed request for a teamApril 29, 2026 19:57
@susnux
susnuxforce-pushed the chore/split-appstore branch from 40c4086 to 9749a51CompareApril 29, 2026 19:58
@susnux
susnux requested review from artonge and skjnldsv and removed request for a team and sorbaughApril 29, 2026 19:58
@susnuxsusnux mentioned this pull request Apr 29, 2026
Merged
6 tasks
@susnux
susnuxforce-pushed the chore/split-appstore branch from 9749a51 to 4be9862CompareApril 29, 2026 20:05
provokateurin
provokateurin previously requested changes Apr 30, 2026
View reviewed changes
Comment threadapps/appstore/lib/Controller/ApiController.php Outdated
/**
* Get all available apps
*
* @return DataResponse<Http::STATUS_OK, list<array{id: string, name: string, description: string, ...}>, array{}>

@provokateurinprovokateurinApr 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this could contain all fields (and would use a type alias).

@susnuxsusnuxMay 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in a follow up - its too much for 1 PR.
See first steps:

Comment threadapps/appstore/lib/Controller/ApiController.php Outdated
Comment threadapps/appstore/lib/Controller/DiscoverController.php Outdated
Comment threadapps/appstore/lib/Controller/DiscoverController.php Outdated
Comment threadapps/appstore/lib/Controller/PageController.php
Comment threadapps/appstore/lib/Controller/PageController.php
Comment threadapps/appstore/lib/Controller/PageController.php Outdated
Comment threadpsalm-strict.xml
Comment threadpsalm-strict.xml
Comment threadpsalm-strict.xml
@susnuxsusnux mentioned this pull request Apr 30, 2026
Merged
7 tasks
artonge
artonge approved these changes Apr 30, 2026
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more manageable, thanks for splitting :)

This was referenced Apr 30, 2026
Merged
Merged
@susnux
susnuxforce-pushed the chore/split-appstore branch from 4be9862 to df0e8acCompareMay 3, 2026 12:29
@susnux
susnuxforce-pushed the chore/split-appstore branch from df0e8ac to fc90582CompareMay 4, 2026 09:33
miaulalala
miaulalala approved these changes May 4, 2026
View reviewed changes

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@susnux
susnuxforce-pushed the chore/split-appstore branch from fc90582 to db937a0CompareMay 4, 2026 10:24
@susnux

susnux commented May 4, 2026

Copy link
Copy Markdown
ContributorAuthor

(conflicts + openapi + rector resolved - no behavior changes)

@susnux
susnuxforce-pushed the chore/split-appstore branch from db937a0 to a943092CompareMay 4, 2026 11:31
@susnux
susnux requested review from a team and nickvergessen as code ownersMay 4, 2026 11:31
@susnux
susnux requested a review from provokateurinMay 4, 2026 11:32
@susnux
susnux dismissed provokateurin’s stale reviewMay 4, 2026 11:32

changes implemented

@susnux
susnuxforce-pushed the chore/split-appstore branch 3 times, most recently from 9ffba47 to 1428ff7CompareMay 4, 2026 16:30
susnux added 5 commits May 5, 2026 10:41
@susnux
refactor: split appstore from settings
5b756ad
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): split controllers and use proper root
f6a37dc
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: apply strict rector rules on appstore
3f87105
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): adjust frontend for new API location
2e0b001
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
ec81e14
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the chore/split-appstore branch from 1428ff7 to ec81e14CompareMay 5, 2026 08:41
@sorbaugh
sorbaugh merged commit fb67d5d into masterMay 5, 2026
234 of 249 checks passed
@sorbaugh
sorbaugh deleted the chore/split-appstore branch May 5, 2026 11:26
@nextcloud-botnextcloud-bot mentioned this pull request May 5, 2026
Merged
@susnuxsusnux mentioned this pull request May 5, 2026
Merged
7 tasks
@DerDreschnerDerDreschner mentioned this pull request May 7, 2026
Merged
7 tasks
This was referenced May 7, 2026
Merged
Merged
This was referenced May 15, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@Blackspell01Blackspell01 mentioned this pull request Jul 2, 2026
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)technical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

6 participants

@susnux@artonge@miaulalala@skjnldsv@provokateurin@sorbaugh