Skip to content

chore: fix strict psalm and rector - #60012

Merged
susnux merged 4 commits into
masterfrom
chore/rector-psalm
Apr 30, 2026
Merged

chore: fix strict psalm and rector#60012
susnux merged 4 commits into
masterfrom
chore/rector-psalm

Conversation

@susnux

@susnuxsusnux commented Apr 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • As cherry picked psalm changes to also cover tests and make use of the phpunit plugin.
  • Fix the strict rector rules to properly autoload OCP otherwise it does not know about those interface¹
  • Fix the strict psalm rules for the same reason to make them aware of our OC and OCP code
  • Apply the changes and committed the results

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux
susnux requested a review from a team as a code ownerApril 30, 2026 09:34
@susnuxsusnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 30, 2026
@susnuxsusnux added this to the Nextcloud 34 milestone Apr 30, 2026
@susnux
susnux requested review from Altahrim, ArtificialOwl, leftybournes, nickvergessen, provokateurin and salmart-dev and removed request for a teamApril 30, 2026 09:34
provokateurin
provokateurin requested changes Apr 30, 2026
View reviewed changes
Comment threadvendor-bin/psalm/composer.json
provokateurinand others added 4 commits April 30, 2026 12:35
@provokateurin@susnux
feat(psalm): Enable PHPUnit plugin
42eebfb
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin@susnux
fix(psalm-strict): Also check app tests
a16c24b
Signed-off-by: provokateurin <kate@provokateurin.de>
@susnux
chore: make psalm and rector strict properly autoload OCP
d3031b8
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: adjust for now fixed strict rector changes
75273a6
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the chore/rector-psalm branch from 97062fa to 75273a6CompareApril 30, 2026 10:35
@susnux
susnux merged commit fdbd39a into masterApr 30, 2026
237 of 245 checks passed
@susnux
susnux deleted the chore/rector-psalm branch April 30, 2026 12:00
This was referenced May 5, 2026
Merged
Merged
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@nickvergessen@CarlSchwan@provokateurin