Uh oh!
There was an error while loading. Please reload this page.
libxml - compare against loaded version - #612
Merged
Merged
Conversation
karlitschek
commented
Jul 27, 2016
Member
nice! please backport |
| version_compare('2.7.0', LIBXML_DOTTED_VERSION) === 1) { | ||
| LIBXML_LOADED_VERSION < 20700 ) { | ||
| $errors[] = array( | ||
| 'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [LIBXML_DOTTED_VERSION]), |
MemberAuthor
There was a problem hiding this comment.
🙈 I didn't noticed that. Yes I will try to get a useful information in a dotted version here.
Thanks, work well! only cosmetic - change: complement: sorry, my english is to bad. i hope you understand me |
* if the compiled in version is older than the loaded version Nextcloud doesn't work * uses the loaded libxml version to check against fixes#205
MorrisJobkeforce-pushed
the
improve-xml-loaded-version-handling
branch
from
July 28, 2016 06:30
9193334 to
740349fCompareMorrisJobke
commented
Jul 28, 2016
MemberAuthor
I fixed the output. |
kasi45
commented
Jul 28, 2016
@MorrisJobke |
nickvergessen
commented
Jul 28, 2016
Member
Nasty math 🙈 👍 |
LukasReschke
commented
Jul 28, 2016
Member
🙈 🙊 🙉 |
This was referenced Jul 28, 2016
R0Wi pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…e-url feat(new-route): added endpoint to call NC getAbsoluteURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#205
@kasi45 Could you check your setup with this change? (I slightly modified the check, because in your scenario it luckily worked, but the comparision wasn't correct ;))
@nickvergessen@LukasReschke@rullzer Please review :)
The issue reported needed this to run Nextcloud on an older Qnap system, so I would vote for a backport. @karlitschek