Skip to content

[stable9] libxml - compare against loaded version - #629

Merged
MorrisJobke merged 1 commit into
stable9from
stable9-backport-612
Jul 28, 2016
Merged

[stable9] libxml - compare against loaded version#629
MorrisJobke merged 1 commit into
stable9from
stable9-backport-612

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

fixes#205

@kasi45@nickvergessen@LukasReschke@rullzer Please review :)

* if the compiled in version is older than the loaded version Nextcloud doesn't work
* uses the loaded libxml version to check against
fixes#205
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jul 28, 2016
@MorrisJobkeMorrisJobke added this to the Nextcloud 9.0.54 milestone Jul 28, 2016
Comment threadlib/private/util.php
$patch = $version;
$errors[] = array(
'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [LIBXML_DOTTED_VERSION]),
'error' => $l->t('libxml2 2.7.0 is at least required. Currently %s is installed.', [$major . '.' . $minor . '.' . $patch]),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... currently loaded

@rullzer

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@LukasReschke

Copy link
Copy Markdown
Member

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@LukasReschke