Skip to content

Add rich link preview to the login page - #6342

Merged
rullzer merged 1 commit into
masterfrom
rich-link-preview
Sep 4, 2017
Merged

Add rich link preview to the login page#6342
rullzer merged 1 commit into
masterfrom
rich-link-preview

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Follow up of #6341fixes#4264

cc @newhinton

@mention-bot

Copy link
Copy Markdown

@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @LukasReschke and @nickvergessen to be potential reviewers.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

codecovBot commented Sep 2, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6342 into master will decrease coverage by 16.33%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #6342 +/- ##
=============================================
- Coverage 53.31% 36.97% -16.34% 
Complexity 22497 22497 =============================================
Files 1403 1403 Lines 87079 87087 +8 Branches 1327 1327 =============================================
- Hits 46422 32197 -14225 - Misses 40657 54890 +14233
Impacted FilesCoverage ΔComplexity Δ
core/Controller/LoginController.php0% <0%> (-77.28%)38 <0> (ø)
...mments/tests/Unit/Controller/NotificationsTest.php0% <0%> (-100%)4% <0%> (ø)
.../Exceptions/EncryptionHeaderKeyExistsException.php0% <0%> (-100%)1% <0%> (ø)
apps/files/lib/Activity/Settings/FileFavorite.php0% <0%> (-100%)8% <0%> (ø)
apps/files/lib/Activity/Settings/FileRestored.php0% <0%> (-100%)8% <0%> (ø)
lib/private/Template/ResourceNotFoundException.php0% <0%> (-100%)2% <0%> (ø)
...ib/private/Contacts/ContactsMenu/ActionFactory.php0% <0%> (-100%)2% <0%> (ø)
apps/federation/lib/Hooks.php0% <0%> (-100%)4% <0%> (ø)
...curity/Exceptions/StrictCookieMissingException.php0% <0%> (-100%)1% <0%> (ø)
...te/Authentication/Token/DefaultTokenCleanupJob.php0% <0%> (-100%)1% <0%> (ø)
... and 479 more

@rullzer
rullzer merged commit 57b74c9 into masterSep 4, 2017
@rullzer
rullzer deleted the rich-link-preview branch September 4, 2017 10:02
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Sep 4, 2017
@MorrisJobke

Copy link
Copy Markdown
Member

Broken unit tests fixed in 0326c2c

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rich Link Preview Extension

4 participants

@juliusknorr@mention-bot@MorrisJobke@rullzer