Skip to content

Fix checkboxes on popover - #6976

Merged
MorrisJobke merged 2 commits into
masterfrom
fix-checkbox-in-popover
Oct 30, 2017
Merged

Fix checkboxes on popover#6976
MorrisJobke merged 2 commits into
masterfrom
fix-checkbox-in-popover

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Oct 26, 2017

Copy link
Copy Markdown
Member

Basic popover

BeforeAfter
kazam_screenshot_00000kazam_screenshot_00001

Sharing popover (not much changes, but removed a lot of unused rules since it's now into all the popovermenus)

BeforeAfter
kazam_screenshot_00003kazam_screenshot_00002

@skjnldsv
Fix checkboxes on popover
419ddea
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Share views fix
97638e7
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added the 2. developing Work in progress label Oct 26, 2017
@skjnldsvskjnldsv self-assigned this Oct 26, 2017
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. regression medium 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 26, 2017
@codecov

codecovBot commented Oct 27, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6976 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #6976 +/- ##
============================================
+ Coverage 52.82% 52.85% +0.03% - Complexity 22802 22814 +12 
============================================
Files 1442 1442 Lines 88562 88632 +70 Branches 1349 1353 +4 ============================================
+ Hits 46783 46848 +65 - Misses 41779 41784 +5
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Log.php79.31% <0%> (ø)50% <0%> (+12%)⬆️
core/js/js.js61.94% <0%> (+0.66%)0% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️
apps/systemtags/js/systemtagsfilelist.js76.37% <0%> (+3.33%)0% <0%> (ø)⬇️

jancborchardt
jancborchardt approved these changes Oct 28, 2017
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

MorrisJobke
MorrisJobke approved these changes Oct 30, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MorrisJobke
MorrisJobke merged commit 42a14ad into masterOct 30, 2017
@MorrisJobke
MorrisJobke deleted the fix-checkbox-in-popover branch October 30, 2017 08:45
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Oct 30, 2017
@MorrisJobkeMorrisJobke mentioned this pull request Oct 30, 2017
Closed
@skjnldsvskjnldsv mentioned this pull request Nov 4, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@jancborchardtjancborchardtjancborchardt approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@pixelipopixelipoAwaiting requested review from pixelipo

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.mediumregression

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@jancborchardt