Uh oh!
There was an error while loading. Please reload this page.
Fix popover layout - #7064
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
Henni, MorrisJobke, jancborchardt, nickvergessen and pixelipoNovember 4, 2017 12:19
Codecov Report
@@ Coverage Diff @@## master #7064 +/- ##
=========================================
Coverage 50.72% 50.72% Complexity 24414 24414 =========================================
Files 1579 1579 Lines 93317 93317 Branches 1359 1359 =========================================
Hits 47338 47338 Misses 45979 45979 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Member
|
skjnldsv
commented
Nov 7, 2017
MemberAuthor
Thanks will fix when home from work! 👌 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
commented
Nov 7, 2017
MemberAuthor
@MorrisJobke All fixed. Please check again :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
MemberAuthor
@nextcloud/designers bump! :) Needed for #7051 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow the various popover layouts broke appart.
My guess is the cleanup we did on various part of the css which may have influenced this.
I also added support for radio since we also support checkboxes after #6976.
Please tests from various locations. Example:
Test template: templatetest.tar.gz
@nextcloud/designers