Uh oh!
There was an error while loading. Please reload this page.
Breadcrumbs refactor - #7051
Conversation
Codecov Report
@@ Coverage Diff @@## master #7051 +/- ##
============================================
+ Coverage 50.72% 50.74% +0.01%
Complexity 24478 24478 ============================================
Files 1581 1581 Lines 93578 93560 -18 Branches 1359 1353 -6 ============================================
+ Hits 47471 47475 +4 + Misses 46107 46085 -22
|
skjnldsv
commented
Nov 4, 2017
@jancborchardt@juliushaertl @nextcloud/javascript |
Pretty much the same for the resize function! 😕 |
e4902df to
5b26a4eCompareSigned-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
b92b9fb to
2348d14CompareSigned-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
d99eaf1 to
fdd7918Compareskjnldsv
commented
Nov 12, 2017
@rullzer, @MorrisJobke, @juliushaertl, @jancborchardt, @ChristophWurst, please help and test it. 😭 |
MorrisJobke
commented
Nov 13, 2017
Even with the latest changes the popup does not show up in Chrome nor in Safari and there is nothing in the console :/ |
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works now (after disabling the gallery app) 👍
| - JAVA_OPTS=-Dselenium.LOGGER.level=WARNING | ||
| when: | ||
| matrix: | ||
| TESTS: acceptance |
There was a problem hiding this comment.
Of course, it was for testing purposes only! :)
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
fdd7918 to
8c2dbebCompare
jancborchardt
left a comment
There was a problem hiding this comment.
With the Gallery fix nextcloud/gallery#325 it seems good now! :) Great work!
MorrisJobke
commented
Nov 13, 2017
@skjnldsv Is this ready for merge or not? (because the label says something different ;)) |
skjnldsv
commented
Nov 13, 2017
It is, I was waiting for other tests to be sure if this was a pr issue or something from @blizzz dev environnement. :) |
Still broken from me, also pristine from git -.- Ill open issues |
Summary here: #7051 (comment)
Fix#5431, fix#6756
Closes#5229
Rebuilding the breadcrumbs design and calculation system for a better result:
Animation ?There are multiple calls forBreadCrumb.setDirectoryInfo&BreadCrumb.setDirectorywhich force re-rendersThere are at least 3BreadCrumb._resizeexecution on init, only one is needed