Skip to content

Fix unit tests for CalendarManager - #7458

Merged
blizzz merged 1 commit into
masterfrom
fix-calendar-manager-unit-tests
Dec 12, 2017
Merged

Fix unit tests for CalendarManager#7458
blizzz merged 1 commit into
masterfrom
fix-calendar-manager-unit-tests

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Beside that:

@georgehrke Where is this actually used? Because I only see that CalendarManager is mapped in the server container to \OC\Calendar\Manager instead - could it be that this one is not used anymore (or vice versa)?

ref #6840 (where it was introduced) and #6884 (which was merged without a failure and then suddenly master had problems)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Dec 12, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Dec 12, 2017
@MorrisJobkeMorrisJobke mentioned this pull request Dec 12, 2017
28 tasks
@georgehrke

Copy link
Copy Markdown
Member

It's used here to connect the dav app to the server's calendar API:

publicfunctionsetupCalendarProvider(ICalendarManager$calendarManager, $userId) {

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2017
@blizzz
blizzz merged commit 115e7e2 into masterDec 12, 2017
@blizzz
blizzz deleted the fix-calendar-manager-unit-tests branch December 12, 2017 09:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@georgehrke@rullzer@blizzz