Skip to content

Nextcloud 13 is not compatible with newer than php 7.2 - #6830

Merged
MorrisJobke merged 1 commit into
masterfrom
nc13_no_later_72
Dec 12, 2017
Merged

Nextcloud 13 is not compatible with newer than php 7.2#6830
MorrisJobke merged 1 commit into
masterfrom
nc13_no_later_72

Conversation

@rullzer

@rullzerrullzer commented Oct 13, 2017

Copy link
Copy Markdown
Member

Easy one.
Just so we don't forget and have people try NC13 with a to new version of php.

@rullzerrullzer added 3. to review Waiting for reviews enhancement labels Oct 13, 2017
@rullzerrullzer added this to the Nextcloud 13 milestone Oct 13, 2017
@nickvergessen

nickvergessen commented Oct 13, 2017

Copy link
Copy Markdown
Member

There should be more? remote.php? ocs/?

@codecov

codecovBot commented Oct 13, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6830 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #6830 +/- ##
============================================
- Coverage 51.11% 51.11% -0.01% 
Complexity 24900 24900 ============================================
Files 1600 1601 +1 Lines 94763 94772 +9 Branches 1367 1367 ============================================
- Hits 48439 48438 -1 - Misses 46324 46334 +10
Impacted FilesCoverage ΔComplexity Δ
ocs/v1.php0% <0%> (ø)0 <0> (ø)⬇️
status.php0% <0%> (ø)0 <0> (ø)⬇️
cron.php0% <0%> (ø)0 <0> (ø)⬇️
index.php0% <0%> (ø)0 <0> (ø)⬇️
ocs/providers.php0% <0%> (ø)0 <0> (ø)⬇️
lib/versioncheck.php0% <0%> (ø)0 <0> (?)
public.php0% <0%> (ø)0 <0> (ø)⬇️
remote.php0% <0%> (ø)0 <0> (ø)⬇️
console.php0% <0%> (ø)0 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
... and 2 more

@rullzer

rullzer commented Oct 13, 2017

Copy link
Copy Markdown
MemberAuthor

@nickvergessen they include base.php

@ChristophWurst

ChristophWurst commented Oct 14, 2017

Copy link
Copy Markdown
Member

There should be more? remote.php? ocs/?

Based on what/where we currently check for a min-version, also console.php should have a check: https://github.com/nextcloud/server/search?utf8=%E2%9C%93&q=PHP_VERSION

@nickvergessen

nickvergessen commented Oct 16, 2017

Copy link
Copy Markdown
Member

they include base.php

yes @rullzer but I don't see any checking there either?

@LukasReschke

LukasReschke commented Oct 19, 2017

Copy link
Copy Markdown
Member

There should be more? remote.php? ocs/?

If we do that we need to also add a 500 error status code. Otherwise our sync clients may get a 200 and sync down the text error message … 😱

@nickvergessen

nickvergessen commented Oct 19, 2017

Copy link
Copy Markdown
Member

Well the same happens when there is another language based error?
That's exactly why I would like to "stop" these pages as well

@MorrisJobke

MorrisJobke commented Nov 9, 2017

Copy link
Copy Markdown
Member

@rullzer Could you make this a 500 page?

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 9, 2017
@MorrisJobke

MorrisJobke commented Dec 8, 2017

Copy link
Copy Markdown
Member

Let's move this to 14 and maybe backport it.

@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 12, 2017
MorrisJobke
MorrisJobke approved these changes Dec 12, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 It now also serves a 500 status code

@MorrisJobke

MorrisJobke commented Dec 12, 2017

Copy link
Copy Markdown
Member

CI failure should be fixed by #7458

@rullzer

rullzer commented Dec 12, 2017

Copy link
Copy Markdown
MemberAuthor

Lets get this into 13 then. So it is there from the start.

@blizzz

blizzz commented Dec 12, 2017

Copy link
Copy Markdown
Member

Should also be documented somewhere, docs or release notes, or both

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2017
@MorrisJobke

MorrisJobke commented Dec 12, 2017

Copy link
Copy Markdown
Member

Should also be documented somewhere, docs or release notes, or both

Already is ;)

@MorrisJobke

MorrisJobke commented Dec 12, 2017

Copy link
Copy Markdown
Member

Let me rebase - to check if CI is green.

@MorrisJobkeMorrisJobke mentioned this pull request Dec 12, 2017
Merged
28 tasks
@rullzer
Nextcloud 13 is not compatible with newer than php 7.2
b8af7ee
Just to avoid users from trying this with a to new (untested) php version
* Moved the check logic to 1 place
* All directly callable scripts just require this on top
* exit hard (-1) so we know scripts won't continue
* Return status 500 so no sync clients will try fancy stuff
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke

MorrisJobke commented Dec 12, 2017

Copy link
Copy Markdown
Member

Failure is due to a connection issue while cloning -> merge

@MorrisJobke
MorrisJobke merged commit 134bd51 into masterDec 12, 2017
@MorrisJobke
MorrisJobke deleted the nc13_no_later_72 branch December 12, 2017 10:27
@MorrisJobkeMorrisJobke mentioned this pull request Feb 7, 2018
Closed
@rullzerrullzer mentioned this pull request Feb 7, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@blizzzblizzzblizzz approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@danxuliudanxuliuAwaiting requested review from danxuliu
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer@nickvergessen@ChristophWurst@LukasReschke@MorrisJobke@blizzz