Skip to content

allow 'Nextcloud' in the user agent string of Android - #7462

Merged
schiessle merged 2 commits into
masterfrom
update-user-agent-regex
Dec 12, 2017
Merged

allow 'Nextcloud' in the user agent string of Android#7462
schiessle merged 2 commits into
masterfrom
update-user-agent-regex

Conversation

@schiessle

Copy link
Copy Markdown
Member

It is already possible for iOS, this PR also enable it for Android. This way we can effectively block all clients which don't support end-to-end encryption. We should backport it so that the new Android client will also work with older Nextcloud releases.

cc @tobiasKaminsky@AndyScherzinger

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@AndyScherzinger

Copy link
Copy Markdown
Member

👍 Nice @schiessle ❤️

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@codecov

codecovBot commented Dec 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7462 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7462 +/- ##
============================================
+ Coverage 51.1% 51.11% +<.01% 
Complexity 24900 24900 ============================================
Files 1601 1601 Lines 94772 94772 Branches 1367 1367 ============================================
+ Hits 48435 48438 +3 + Misses 46337 46334 -3
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
core/js/js.js63.55% <0%> (+0.56%)0% <0%> (ø)⬇️

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle
schiessleforce-pushed the update-user-agent-regex branch from 062d66d to caff52dCompareDecember 12, 2017 13:00
@schiessle
schiessle merged commit acb395c into masterDec 12, 2017
@schiessle
schiessle deleted the update-user-agent-regex branch December 12, 2017 13:37
@AndyScherzingerAndyScherzinger removed the 3. to review Waiting for reviews label Dec 12, 2017
@MorrisJobkeMorrisJobke mentioned this pull request Dec 13, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@schiessle@AndyScherzinger@rullzer@MorrisJobke