13.0.0 beta3

[MorrisJobke]

Includes:

• Fix error log on PHP 7.2 Fix error log on PHP 7.2 #7466 <- that is the main reason for the beta 3 to not have issues with users, that test it on PHP 7.2
• The user displayNameResolver is specific to users, not the comments app The user displayNameResolver is specific to users, not the comments app #7472
• Fixed firefox guest header height Fixed firefox guest header height #7470
• Fix filename typo Fix filename typo #7465
• allow 'Nextcloud' in the user agent string of Android allow 'Nextcloud' in the user agent string of Android #7462
• Show tha copy share link button properly inline Show tha copy share link button properly inline #7476
• Fixes hex2bin() in LDAP Fixes bin2hex() in LDAP #7479

[jospoortvliet]

go for it...

[MorrisJobke]

I would block this until @blizzz had time to had a look into #7400 because we experience this as well.

[codecov]

Codecov Report

Merging #7475 into master will increase coverage by 20.44%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7475 +/- ##
=============================================
+ Coverage 30.66% 51.11% +20.44% 
Complexity 24901 24901 =============================================
Files 1601 1601 Lines 94774 94774 Branches 1367 1367 =============================================
+ Hits 29059 48440 +19381 + Misses 65715 46334 -19381

Impacted Files	Coverage Δ	Complexity Δ
version.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Files/Storage/DAV.php	65.4% <0%> (+0.21%)	163% <0%> (ø)	⬇️
lib/private/Files/Stream/Encryption.php	75.22% <0%> (+0.45%)	54% <0%> (ø)	⬇️
apps/theming/lib/ThemingDefaults.php	92.08% <0%> (+0.71%)	48% <0%> (ø)	⬇️
lib/private/Setup.php	12.76% <0%> (+0.85%)	50% <0%> (ø)	⬇️
lib/public/AppFramework/Db/Mapper.php	99.12% <0%> (+0.87%)	30% <0%> (ø)	⬇️
lib/private/legacy/image.php	38.51% <0%> (+0.88%)	208% <0%> (ø)	⬇️
lib/private/Group/Group.php	88.88% <0%> (+0.92%)	52% <0%> (ø)	⬇️
lib/private/App/DependencyAnalyzer.php	95.59% <0%> (+1.25%)	63% <0%> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	91.93% <0%> (+1.61%)	29% <0%> (ø)	⬇️
... and 375 more

[MorrisJobke]

I would block this until @blizzz had time to had a look into #7400 because we experience this as well.

Fix for this is in: #7479

[tiiiecherle]

It would be nice to see a fix for this #7380 included as this error is still present when using php 7.2 with the latest git nextcloud version.

According to
https://stackoverflow.com/questions/47656426/magento-2-2-1-unable-to-save-product-error-narrowing-occurred-during-type-infe

opcache_reset();

has to be included at the correct position.

Thanks in advance

[MorrisJobke]

opcache_reset();

We already do this:

server/lib/base.php

Line 297 in c603f54

opcache_reset();

That code is executed everytime the upgrade page is shown (just before you click the "Upgrade now" button.

[MorrisJobke]

Rebased to latest master.

[tiiiecherle]

opcache_reset();
We already do this:

server/lib/base.php
Line 297 in c603f54
opcache_reset();
That code is executed everytime the upgrade page is shown (just before you click the "Upgrade now" button.

ok, but the error from #7380 is shown on every restart of the webserver. Would be nice to see this fixed as this is the last error in the log for me after upgrading to php 7.2 and using the latest git version of nextcloud from around 5 hours ago.

Thanks

[rullzer]

@tiiiecherle we won't put an opcache_reset(); in the index.php. That would clear all caching of the compiled php files. This would put more load on your server and slow down each and all requests.

[tiiiecherle]

@tiiiecherle we won't put an opcache_reset(); in the index.php. That would clear all caching of the compiled php files. This would put more load on your server and slow down each and all requests.

ok, how can the error be solved? Or is it something that has to be fixed in the php packages?

[MorrisJobke]

ok, how can the error be solved? Or is it something that has to be fixed in the php packages?

It looks like this can only be fixed by an upcoming PHP release. I just checked and the opcache_reset does not solve the issue.

[tiiiecherle]

It looks like this can only be fixed by an upcoming PHP release. I just checked and the opcache_reset does not solve the issue.

ok, thanks. Perhaps the issue can be forwarded to their developers.

[MorrisJobke]

ok, thanks. Perhaps the issue can be forwarded to their developers.

AFAIK it is already fixed by PHP and the next release is in January.