Uh oh!
There was an error while loading. Please reload this page.
Fixed firefox guest header height - #7470
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
jancborchardt
commented
Dec 12, 2017
It’s fine by me. :) But FYI on mobile there’s a scrollbar very early (which was the issue originally to be solved by this whole working on the log in screen I think ;) |
@jancborchardt what kind of mobile is this? This looks very small! :/ EDIT there is an empty div which is 70px high named '.push', any idea why it's there? @jancborchardt |
jancborchardt
commented
Dec 12, 2017
@skjnldsv it’s Firefox responsive design mode, but looks the same on a Fairphone 2 for example (5" screen). And keep in mind the keyboard will also be shown there. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@## master #7470 +/- ##
=========================================
Coverage 51.11% 51.11% Complexity 24900 24900 =========================================
Files 1601 1601 Lines 94772 94772 Branches 1367 1367 =========================================
Hits 48438 48438 Misses 46334 46334 |
skjnldsv
commented
Dec 12, 2017
Okay, fixed, It was an old div designed to push the footer 😱 |
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good to me now! 🚀 :)
After #7249