Uh oh!
There was an error while loading. Please reload this page.
The user displayNameResolver is specific to users, not the comments app - #7472
Merged
Merged
Conversation
Other apps like spreed rely on it, and only can resolver per type can be registered anyhow. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## master #7472 +/- ##
============================================
+ Coverage 51.11% 51.11% +<.01% - Complexity 24900 24901 +1
============================================
Files 1601 1601 Lines 94772 94774 +2 Branches 1367 1367 ============================================
+ Hits 48438 48440 +2
Misses 46334 46334
|
danxuliu
approved these changes
Dec 12, 2017
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works (both in Comments and in Talk) 👍
rullzer
approved these changes
Dec 12, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nextcloud/spreed#517
How to test: write a comment with a mention. If the display name keeps being visible everything continues to work :)