Skip to content

Fix box shadow of header elements - #7572

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-box-shadow
Dec 20, 2017
Merged

Fix box shadow of header elements#7572
MorrisJobke merged 1 commit into
masterfrom
fix-box-shadow

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Dec 19, 2017

Copy link
Copy Markdown
Member
  • unify shadow blur from 3px to 10px
  • remove opacity of background of app labels
  • for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported)

Found while reviewing nextcloud/notifications#89

cc @nextcloud/designers

Before (opacity, bigger blur, no shadow on notifications in Safari):

bildschirmfoto 2017-12-19 um 12 10 16

After:

bildschirmfoto 2017-12-19 um 12 09 56

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring UX issue with possibly simple fix. labels Dec 19, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Dec 19, 2017
@codecov

codecovBot commented Dec 19, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7572 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7572 +/- ##
============================================
+ Coverage 51.16% 51.16% +<.01% 
Complexity 24883 24883 ============================================
Files 1602 1602 Lines 94730 94730 Branches 1368 1368 ============================================
+ Hits 48470 48471 +1 + Misses 46260 46259 -1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@jancborchardt

Copy link
Copy Markdown
Member

Good stuff, but why reduce it from 10px which we used basically everywhere to 3px? It looks a bit strange and more like a thick border than a slight shadow.

@MorrisJobke

MorrisJobke commented Dec 19, 2017

Copy link
Copy Markdown
MemberAuthor

Good stuff, but why reduce it from 10px which we used basically everywhere to 3px? It looks a bit strange and more like a thick border than a slight shadow.

Because we use that in our newer filters ;) See the line I just changed, I thought that we move to that. Otherwise we need to touch a lot more occurrences.

@skjnldsv

Copy link
Copy Markdown
Member

I disagree! The filter: drop-shadow is far better than the box-shadow as the arrow isn't included in the shadow generation. I'm against the removal of this.

What's up with safari anyway? it should supports filter? https://caniuse.com/#feat=css-filters 😕

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Usually it does this, but somehow not for the notifications drop down. I will check tomorrow and adapt this pr then

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Okay - I moved to the 10px and to the filter: drop-shadow. I also added fixes for IE 11, because this supports only box-shadow. I tested it and it works now 👍

* unify shadow blur from 3px to 10px
* remove opacity of background of app labels
* for IE: use box-shadow as fallback (because the filter: drop-shadow is not supported)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobke merged commit 0b8a9fc into masterDec 20, 2017
@MorrisJobke
MorrisJobke deleted the fix-box-shadow branch December 20, 2017 12:52
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.papercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@jancborchardt@skjnldsv